Skip to content

FIX: timeout and RT calculation in wait_for_button_press #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmc-law
Copy link

@rmc-law rmc-law commented Jul 18, 2023

  1. Original timed_out = t1 - t0 < timeout always returns True immediately if timeout is > 0. Changing the sign of the inequality to > only returns True when time elapsed (i.e., t1 - t0) is greater than the desired period (i.e., timeout)
  2. Function original returns t1, which is less informative than reaction time, which is t1 - t0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant