update dev: update OmniXXX: handle interrupted bolus during pod fault correctly #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotfix/main fastlane 2.228.0
main branch: Use a special version of fastlane to enable Add Identifiers
Bump dev branch to 3.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fix the case where a pod fault is treated as an unacknowledged command during an interrupted bolus and the undelivered insulin is subtracted twice from the original bolus amount.
This was reported for both Trio and Loop (the two apps use a common set of OmniBLE and OmniKit modules):
Method
The OmniXXX repositories were updated and the code modification tested as reported in these comments:
merge hotfix main into hotfix dev
This method aligns commits between main and dev. Several commits (with no changes to dev code) show up in this PR, but this brings main and dev commit list into alignment. It should make future updates cleaner if we follow the gitflow process.