Skip to content

Refactor AdminConsole vs. OptionalFeatureService #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactor AdminConsole vs. OptionalFeatureService #1091

wants to merge 1 commit into from

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Jul 8, 2025 •
edited
Loading

Rationale

Register feature flag via OptionalFeatureService. Move registration later in module lifecycle to ensure service is ready.

Related Pull Requests

@labkey-adam labkey-adam requested a review from a team July 8, 2025 18:48
labkey-jeckels
labkey-jeckels approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still happen soon enough for startup properties work?

@labkey-adam
Copy link
Contributor Author

Does this still happen soon enough for startup properties work?

Yes, init() is very very early; typically, the earliest module code that runs. And startup properties are handled very very late, see OptionalFeatureStartupListener.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-adam @labkey-jeckels