Support container permission inheritance in search SecurityQuery #6833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Data Finder study search wasn't working (i.e., no hits for readers) for study folders that inherit their permissions. The associated search documents were intended to permission check two containers: the "cube" container (where lists reside) and each individual study container. The study container ID was therefore stored in the indexed document as resourceId. However, resourceId was designed to represent a resource within a container, not a completely separate container.
SecurityQueryhas no provision for container policy inheritance, so inherited policies resulted in no permissions.https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53420
Tasks 📍