Improve detection of an idle indexer #6829
Open
+100
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // The indexer uses multiple threads for different types of work. Queue a Runnable first, and when it executes, | ||
| // queue the Item | ||
| SearchService.IndexTask itemTask = createTask("WaitForIndexer", new SearchService.TaskListener() |
There was a problem hiding this comment.
This looks fine. It's a little more complicated than necessary. I think you can use the one task=createTask(). It will fire success when all the associated items are done. So the initial addRunnable(), and the second addNoop() can be run using the same task.
There was a problem hiding this comment.
With a single task, is there a way to guarantee that the Runnable finishes before the Item goes into the queue, and that you get a single notification at the end of both of them?
There was a problem hiding this comment.
I see. As long as the Item gets added before the Runnable finishes, we'll get a single success notification when the Item completes.
|
After running locally, I ended up with several of these in my server log: |
| if (res == 0 && o != this) | ||
| res = (seqNum < o.seqNum ? -1 : 1); | ||
| return res; | ||
| } |
| // queue an Item on every task | ||
| task.addRunnable(priority, () -> { | ||
| _tasks.forEach(t -> t.addNoop(priority, latch)); | ||
| _defaultTask.addNoop(priority, latch); |
There was a problem hiding this comment.
This seems fine, but does TaskListener not work?
| @@ -25,6 +25,7 @@ | |||
| import java.util.Collections; | |||
| import java.util.IdentityHashMap; | |||
| import java.util.Map; | |||
| import java.util.concurrent.CountDownLatch; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We see intermittent failures when automated tests delete containers while indexing is still running. We need to check both
ItemandRunnablequeues. An example is Issue 53417.Changes
Runnableand when it completes, queue theItem