Skip to content

Add rooms to housing problems #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: release24.11-SNAPSHOT
Choose a base branch
from
Draft

Add rooms to housing problems #1283

wants to merge 5 commits into from

Conversation

brentlogan
Copy link
Collaborator

@brentlogan brentlogan commented Mar 11, 2025 •
edited
Loading

Rationale

The existing code provides the objectId of the multiple rooms an animal was assigned to. This is unfriendly to our users. Reported in EHR Issue 10404: Error in Animals with duplicate housing entries table.

Related Pull Requests

Changes

  • Replace the study.housingProblems.sql built-in table in the ehr module with a new study.housingProblems.sql built-in table in the onprc_ehr module. This new table lists the multiple rooms an animal is housed in.
  • Add the new housingProblems.sql table to onprc_ehr.xml.

@brentlogan brentlogan marked this pull request as draft March 11, 2025 23:00
@github-actions GitHub Actions
Copy link

ERROR: A pull request from 24.11_fb_addRoomsToHousingProblems is expected to target release24.11-SNAPSHOT, not develop

@brentlogan brentlogan changed the base branch from develop to release24.11-SNAPSHOT March 11, 2025 23:01
@brentlogan brentlogan requested a review from jonesgaohsu March 22, 2025 14:58
@brentlogan
Copy link
Collaborator Author

@jonesgaohsu please review this PR. It's currently installed on primetestB, which has multiple housing records entered for 36936. Thanks!

@brentlogan brentlogan changed the title add rooms to housing problems Add rooms to housing problems Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesgaohsu jonesgaohsu Awaiting requested review from jonesgaohsu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brentlogan