-
Notifications
You must be signed in to change notification settings - Fork 0
add run! #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbrea
wants to merge
1
commit into
master
Choose a base branch
from
jb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add run! #5
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,49 @@ | ||
module ApproxInferenceBase | ||
using Distributions | ||
using Random | ||
include("priors.jl") | ||
using Distributions | ||
using Random | ||
export run! | ||
include("priors.jl") | ||
|
||
""" | ||
run!(method, model, data; | ||
verbosity = 0, callback = () -> nothing, rng = Random.GLOBAL_RNG) | ||
|
||
Run approximate inference `method` on `model` and `data`. | ||
The `model` should be a callable object (function or functor) with one argument | ||
and return something that can be compared to the `data`. The comparison metric is | ||
defined in the `method`. | ||
Handling of constants and extraction of summary statistics should be done in | ||
the `model` (see examples below). | ||
Verbosity levels are `verbosity = 0` (silent), `verbosity = 1` (progress), | ||
`verbosity = 2` (detailed). | ||
Callbacks `callback` are callable objects with no argument that are called after | ||
every iteration of an iterative `method`. Custom random number generators can be | ||
given through the argument `rng`. | ||
|
||
# Model examples | ||
``` | ||
# simple model | ||
model(params) = sum(params) | ||
|
||
# complex model with constants | ||
complex_model(params, constants) = sum(params) + sum(constants) | ||
model(params) = let constants = [1, 2, 3] | ||
complex_model(params, constants) | ||
end | ||
|
||
# extracting summary statistics | ||
raw_model(params) = rand(4, 3) | ||
model(params) = mean(raw_model(params), dims = 2) | ||
|
||
# functor | ||
struct Model | ||
options | ||
end | ||
(m::Model)(params) = sum(params) + sum(m.options) | ||
``` | ||
""" | ||
function run!(method, model, data; | ||
verbosity = 0, callback = () -> nothing, rng = Random.GLOBAL_RNG) | ||
throw(MethodError(run!, (method, model, data))) | ||
end | ||
end # module |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to believe that maybe it is better not to talk about data at all, perhaps it is best to ask users to directly return a cost (or a vector of costs if it makes sense for some algorithms) in this way data could in principle change during inference in a user defined way, what do you think?