Skip to content

Minor fixes #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2025
Merged

Minor fixes #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f88fb0d
Fix wrong label for clustering coefficient
JohT Jun 19, 2025
5ab421a
Fix wrong comment about bridges parameters
JohT Jun 23, 2025
a5a0333
Fix scaler and use default values of page and article rank
JohT Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_2a_Page_Rank_Estimate.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ CALL gds.pageRank.write.estimate(
$dependencies_projection + '-cleaned', {
writeProperty: $dependencies_projection_write_property
,maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L1Norm"
})
YIELD nodeCount, relationshipCount, bytesMin, bytesMax, heapPercentageMin, heapPercentageMax, treeView
RETURN nodeCount, relationshipCount, bytesMin, bytesMax, heapPercentageMin, heapPercentageMax, treeView
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_2b_Page_Rank_Statistics.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
CALL gds.pageRank.stats(
$dependencies_projection + '-cleaned', {
maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L1Norm"
})
YIELD ranIterations
,didConverge
Expand Down
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_3c_Page_Rank_Mutate.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
CALL gds.pageRank.mutate(
$dependencies_projection + '-cleaned', {
maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,scaler: "L2Norm"
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,mutateProperty: $dependencies_projection_write_property
})
Expand Down
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_3d_Page_Rank_Stream.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
CALL gds.pageRank.stream(
$dependencies_projection + '-cleaned', {
maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L2Norm"
})
YIELD nodeId, score
WITH gds.util.asNode(nodeId) AS member, score
Expand Down
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_3e_Page_Rank_Write.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
CALL gds.pageRank.write(
$dependencies_projection + '-cleaned', {
maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L2Norm"
,writeProperty: $dependencies_projection_write_property
})
YIELD nodePropertiesWritten
Expand Down
5 changes: 1 addition & 4 deletions cypher/Centrality/Centrality_4a_Article_Rank_Estimate.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,8 @@
CALL gds.articleRank.write.estimate(
$dependencies_projection + '-cleaned', {
writeProperty: $dependencies_projection_write_property
,maxIterations: 30
,dampingFactor: 0.85
,tolerance: 0.00000001
,maxIterations: 50
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L1Norm"
})
YIELD nodeCount, relationshipCount, bytesMin, bytesMax, heapPercentageMin, heapPercentageMax, treeView
RETURN nodeCount, relationshipCount, bytesMin, bytesMax, heapPercentageMin, heapPercentageMax, treeView
5 changes: 1 addition & 4 deletions cypher/Centrality/Centrality_4b_Article_Rank_Statistics.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@

CALL gds.articleRank.stats(
$dependencies_projection + '-cleaned', {
maxIterations: 30
,dampingFactor: 0.85
,tolerance: 0.00000001
maxIterations: 50
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L1Norm"
})
YIELD ranIterations
,didConverge
Expand Down
5 changes: 1 addition & 4 deletions cypher/Centrality/Centrality_4c_Article_Rank_Mutate.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@

CALL gds.articleRank.mutate(
$dependencies_projection + '-cleaned', {
maxIterations: 30
,dampingFactor: 0.85
,tolerance: 0.00000001
,scaler: "L2Norm"
maxIterations: 50
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,mutateProperty: $dependencies_projection_write_property
})
Expand Down
5 changes: 1 addition & 4 deletions cypher/Centrality/Centrality_4d_Article_Rank_Stream.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@

CALL gds.articleRank.stream(
$dependencies_projection + '-cleaned', {
maxIterations: 30
,dampingFactor: 0.85
,tolerance: 0.00000001
maxIterations: 50
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L2Norm"
})
YIELD nodeId, score
WITH gds.util.asNode(nodeId) AS member, score
Expand Down
3 changes: 0 additions & 3 deletions cypher/Centrality/Centrality_4e_Article_Rank_Write.cypher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
CALL gds.articleRank.write(
$dependencies_projection + '-cleaned', {
maxIterations: 50
,dampingFactor: 0.85
,tolerance: 0.00000001
,relationshipWeightProperty: CASE $dependencies_projection_weight_property WHEN '' THEN null ELSE $dependencies_projection_weight_property END
,scaler: "L2Norm"
,writeProperty: $dependencies_projection_write_property
})
YIELD nodePropertiesWritten
Expand Down
4 changes: 2 additions & 2 deletions scripts/reports/CentralityCsv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,9 @@ runCentralityAlgorithms() {
#
# Required Parameters:
# - dependencies_projection=...
# Name prefix for the in-memory projection name for dependencies. Example: "package"
# Name prefix for the in-memory projection name for dependencies. Example: "package-centrality"
# - dependencies_projection_node=...
# Label of the nodes that will be used for the projection. Example: "centralityPageRank"
# Label of the nodes that will be used for the projection. Example: "Package"
# - dependencies_projection_weight_property=...
# Name of the node property that contains the dependency weight. Example: "weight"
runUndirectedCentralityAlgorithms() {
Expand Down
2 changes: 1 addition & 1 deletion scripts/reports/CommunityCsv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ calculateLocalClusteringCoefficient() {
local PROJECTION_CYPHER_DIR="${CYPHER_DIR}/Dependencies_Projection"

local writePropertyName="dependencies_projection_write_property=communityLocalClusteringCoefficient"
local writeLabelName="dependencies_projection_write_label=MaximumKCut"
local writeLabelName="dependencies_projection_write_label=LocalClusteringCoefficient"

# Statistics
execute_cypher "${COMMUNITY_DETECTION_CYPHER_DIR}/Community_Detection_10a_LocalClusteringCoefficient_Estimate.cypher" "${@}" "${writePropertyName}"
Expand Down
Loading