Added warning label that allows user to jump to already existing entry

CHANGELOG.md

@@ -13,6 +13,7 @@
 
 - We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189)
 - We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842)
+- When adding a duplicate entry, display warning label that allows user to jump to it instead. [#13261](https://github.com/JabRef/jabref/issues/13261)
 - We added the field `monthfiled` to the default list of fields to resolve BibTeX-Strings for [#13375](https://github.com/JabRef/jabref/issues/13375)
 
 ### Changed
@@ -39,6 +40,7 @@
 - We added a new setting in the 'Entry Editor' preferences to hide the 'File Annotations' tab when no annotations are available. [#13143](https://github.com/JabRef/jabref/issues/13143)
 - We added support for multi-file import across different formats. [#13269](https://github.com/JabRef/jabref/issues/13269)
 
+
 ### Changed
 
 - We moved some functionality from the graphical application `jabref` with new command verbs `generate-citation-keys`, `check-consistency`, `fetch`, `search`, `convert`, `generate-bib-from-aux`, `preferences` and `pdf` to the new toolkit. [#13012](https://github.com/JabRef/jabref/pull/13012) [#110](https://github.com/JabRef/jabref/issues/110)

jabgui/src/main/java/module-info.java

@@ -188,5 +188,6 @@
     requires org.antlr.antlr4.runtime;
     requires org.libreoffice.uno;
     requires com.dlsc.pdfviewfx;
+    requires jbibtex;
     // endregion
 }

jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java

@@ -2,6 +2,7 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Optional;
 
@@ -10,6 +11,7 @@
 import javafx.scene.control.Button;
 import javafx.scene.control.ButtonType;
 import javafx.scene.control.ComboBox;
+import javafx.scene.control.Hyperlink;
 import javafx.scene.control.Label;
 import javafx.scene.control.RadioButton;
 import javafx.scene.control.Tab;
@@ -19,6 +21,7 @@
 import javafx.scene.control.TitledPane;
 import javafx.scene.control.ToggleGroup;
 import javafx.scene.control.Tooltip;
+import javafx.scene.layout.HBox;
 import javafx.scene.layout.TilePane;
 import javafx.stage.Screen;
 import javafx.stage.Stage;
@@ -43,11 +46,15 @@
 import org.jabref.logic.importer.fetcher.isbntobibtex.IsbnFetcher;
 import org.jabref.logic.importer.plaincitation.PlainCitationParserChoice;
 import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.layout.LayoutFormatter;
+import org.jabref.logic.layout.format.DOIStrip;
 import org.jabref.logic.util.TaskExecutor;
+import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.database.BibDatabaseMode;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibEntryType;
 import org.jabref.model.entry.BibEntryTypesManager;
+import org.jabref.model.entry.field.StandardField;
 import org.jabref.model.entry.identifier.ArXivIdentifier;
 import org.jabref.model.entry.identifier.DOI;
 import org.jabref.model.entry.identifier.ISBN;
@@ -86,6 +93,9 @@ public class NewEntryView extends BaseDialog<BibEntry> {
     @Inject private FileUpdateMonitor fileUpdateMonitor;
 
     private final ControlsFxVisualizer visualizer;
+    private BibEntry duplicateEntry;
+    private final HashMap<String, BibEntry> doiCache = new HashMap<String, BibEntry>();
+    private boolean isCacheInitialized = false;
 
     @FXML private ButtonType generateButtonType;
     private Button generateButton;
@@ -115,6 +125,8 @@ public class NewEntryView extends BaseDialog<BibEntry> {
 
     @FXML private TextArea bibtexText;
 
+    @FXML private HBox duplicateWarningBox;
+    @FXML private Hyperlink duplicateSelectLink;
     private BibEntry result;
 
     public NewEntryView(NewEntryDialogTab initialApproach, GuiPreferences preferences, LibraryTab libraryTab, DialogService dialogService) {
@@ -212,6 +224,82 @@ public void initialize() {
         initializeSpecifyBibTeX();
     }
 
+    private void checkDOI(String doiInput) {
+        if (doiInput == null || doiInput.isBlank()) {
+            viewModel.isDuplicateEntryProperty().set(false);
+            duplicateEntry = null;
+            return;
+        }
+
+        LayoutFormatter doiStrip = new DOIStrip();
+        String normalizedInput = doiStrip.format(doiInput);
+
+        if (!isCacheInitialized) {
+            doiCache.clear();
+            BibDatabaseContext databaseContext = stateManager.getActiveDatabase().orElseThrow(() -> new NullPointerException("no active library found !"));
+
+            for (BibEntry entry : databaseContext.getEntries()) {
+                entry.getField(StandardField.DOI)
+                     .map(doiStrip::format)
+                     .ifPresent(strippedDoi -> doiCache.put(strippedDoi.toLowerCase(), entry));
+            }
+
+            isCacheInitialized = true;
+        }
+
+        BibEntry matchedEntry = doiCache.get(normalizedInput.toLowerCase());
+
+        if (matchedEntry != null) {
+            duplicateEntry = matchedEntry;
+            viewModel.isDuplicateEntryProperty().set(true);
+        } else {
+            duplicateEntry = null;
+            viewModel.isDuplicateEntryProperty().set(false);
+        }
+    }
+
+     private void initializeCreateEntry() {
+        entryRecommendedTitle.managedProperty().bind(entryRecommendedTitle.visibleProperty());
+        entryRecommendedTitle.expandedProperty().bindBidirectional(preferences.typesRecommendedExpandedProperty());
+        entryRecommended.managedProperty().bind(entryRecommended.visibleProperty());
+
+        entryOtherTitle.managedProperty().bind(entryOtherTitle.visibleProperty());
+        entryOtherTitle.expandedProperty().bindBidirectional(preferences.typesOtherExpandedProperty());
+        entryOther.managedProperty().bind(entryOther.visibleProperty());
+
+        entryCustomTitle.managedProperty().bind(entryCustomTitle.visibleProperty());
+        entryCustomTitle.expandedProperty().bindBidirectional(preferences.typesCustomExpandedProperty());
+        entryCustom.managedProperty().bind(entryCustom.visibleProperty());
+
+        final boolean isBiblatexMode = libraryTab.getBibDatabaseContext().isBiblatexMode();
+
+        List<BibEntryType> recommendedEntries;
+        List<BibEntryType> otherEntries;
+        if (isBiblatexMode) {
+            recommendedEntries = BiblatexEntryTypeDefinitions.RECOMMENDED;
+            otherEntries = new ArrayList<>(BiblatexEntryTypeDefinitions.ALL);
+            otherEntries.removeAll(recommendedEntries);
+            otherEntries.addAll(BiblatexSoftwareEntryTypeDefinitions.ALL);
+            otherEntries.addAll(BiblatexAPAEntryTypeDefinitions.ALL);
+        } else {
+            recommendedEntries = BibtexEntryTypeDefinitions.RECOMMENDED;
+            otherEntries = new ArrayList<>(BiblatexEntryTypeDefinitions.ALL);
+            otherEntries.removeAll(recommendedEntries);
+            otherEntries.addAll(IEEETranEntryTypeDefinitions.ALL);
+        }
+        addEntriesToPane(entryRecommended, recommendedEntries);
+        addEntriesToPane(entryOther, otherEntries);
+
+        final BibEntryTypesManager entryTypesManager = Injector.instantiateModelOrService(BibEntryTypesManager.class);
+        final BibDatabaseMode customTypesDatabaseMode = isBiblatexMode ? BibDatabaseMode.BIBLATEX : BibDatabaseMode.BIBTEX;
+        final List<BibEntryType> customEntries = entryTypesManager.getAllCustomTypes(customTypesDatabaseMode);
+        if (customEntries.isEmpty()) {
+            entryCustomTitle.setVisible(false);
+        } else {
+            addEntriesToPane(entryCustom, customEntries);
+        }
+    }
+
     private void initializeAddEntry() {
         entryRecommendedTitle.managedProperty().bind(entryRecommendedTitle.visibleProperty());
         entryRecommendedTitle.expandedProperty().bindBidirectional(preferences.typesRecommendedExpandedProperty());
@@ -260,7 +348,9 @@ private void initializeLookupIdentifier() {
         //       method (each automatically independently, or all through the same fetcher).
         idText.setPromptText(Localization.lang("Enter the reference identifier to search for."));
         idText.textProperty().bindBidirectional(viewModel.idTextProperty());
-        final String clipboardText = ClipBoardManager.getContents().trim();
+
+        duplicateWarningBox.visibleProperty().bind(viewModel.isDuplicateEntryProperty());
+        duplicateWarningBox.managedProperty().bind(viewModel.isDuplicateEntryProperty());
 
         ToggleGroup toggleGroup = new ToggleGroup();
         idLookupGuess.setToggleGroup(toggleGroup);
@@ -278,6 +368,9 @@ private void initializeLookupIdentifier() {
             idText.setText(ClipBoardManager.getContents().trim());
             idText.selectAll();
 
+            // since the clipboard automatically pastes the DOI in the textfield, a check here is also required !
+            checkDOI(ClipBoardManager.getContents().trim());
+
             Identifier id = validClipboardId.get();
             Platform.runLater(() -> {
                 idLookupSpecify.setSelected(true);
@@ -303,6 +396,16 @@ private void initializeLookupIdentifier() {
 
         idErrorInvalidText.visibleProperty().bind(viewModel.idTextValidatorProperty().not());
         idErrorInvalidFetcher.visibleProperty().bind(idLookupSpecify.selectedProperty().and(viewModel.idFetcherValidatorProperty().not()));
+
+        idText.textProperty().addListener((_, _, newText) -> {
+            checkDOI(newText);
+        });
+
+        duplicateSelectLink.setOnAction(_ -> {
+            if (duplicateEntry != null) {
+                libraryTab.showAndEdit(duplicateEntry);
+            }
+        });
     }
 
     private void initializeInterpretCitations() {

jabgui/src/main/java/org/jabref/gui/newentry/NewEntryViewModel.java

@@ -62,6 +62,7 @@ public class NewEntryViewModel {
 
     private final BooleanProperty executing;
     private final BooleanProperty executedSuccessfully;
+    private final BooleanProperty isDuplicateEntry = new SimpleBooleanProperty(false);
 
     private final StringProperty idText;
     private final Validator idTextValidator;
@@ -130,6 +131,10 @@ public NewEntryViewModel(GuiPreferences preferences,
         bibtexWorker = null;
     }
 
+    public BooleanProperty isDuplicateEntryProperty() {
+        return isDuplicateEntry;
+    }
+
     public ReadOnlyBooleanProperty executingProperty() {
         return executing;
     }

jabgui/src/main/resources/org/jabref/gui/newentry/NewEntry.fxml

@@ -4,6 +4,7 @@
 <?import javafx.scene.control.ButtonType?>
 <?import javafx.scene.control.ComboBox?>
 <?import javafx.scene.control.DialogPane?>
+<?import javafx.scene.control.Hyperlink?>
 <?import javafx.scene.control.Label?>
 <?import javafx.scene.control.RadioButton?>
 <?import javafx.scene.control.Tab?>
@@ -64,6 +65,10 @@
                             </tooltip>
                         </TextField>
                     </HBox>
+                    <HBox fx:id="duplicateWarningBox" alignment="CENTER_LEFT" spacing="5.0">
+                        <Label fx:id="duplicateSelectLabel" text="Entry already existing in library."/>
+                        <Hyperlink fx:id="duplicateSelectLink" text="%Select entry"/>
+                    </HBox>
                     <VBox spacing="5.0">
                         <RadioButton fx:id="idLookupGuess" text="%Automatically determine identifier type">
                             <tooltip>

jablib/src/main/java/org/jabref/logic/database/DuplicateCheck.java

@@ -76,8 +76,8 @@ public DuplicateCheck(BibEntryTypesManager entryTypesManager) {
 
     private static boolean haveSameIdentifier(final BibEntry one, final BibEntry two) {
         return one.getFields().stream()
-                .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))
-                .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));
+                  .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))
+                  .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));
     }
 
     private static boolean haveDifferentEntryType(final BibEntry one, final BibEntry two) {