Skip to content

Speed up build by making assumptions #13388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Speed up build by making assumptions #13388

merged 1 commit into from
Jun 21, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 21, 2025

We generate *.mv and citation-style-catalog.json.

Gradle runs these tasks even if the input directory does not change.

The input directory do not change that often; ignoring these speeds up the build significantly.

Assumptions:

  • GitHub CI starts on blank build directory
  • Developers seldomly work on parts of jabref requiring fresh abbreviation lists and new/other citation styles
  • If developers work in the area of mv files, they will refresh these files on their own.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added automerge PR is tagged with that label will be merged if workflows are green dev: build-system labels Jun 21, 2025
@koppor koppor enabled auto-merge June 21, 2025 13:03
Copy link

trag-bot bot commented Jun 21, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit 8f92294 Jun 21, 2025
49 of 69 checks passed
@koppor koppor deleted the speedup-build branch June 21, 2025 13:30
Siedlerchr added a commit that referenced this pull request Jun 22, 2025
* upstream/main:
  Fix patterns
  Fix pr-comment.yml
  Try to fix ghprcomment.yml
  Rich diff for Metadata Group Tree External changes (#13325)
  New translations jabref_en.properties (Portuguese, Brazilian) (#13391)
  Speed up build by making assumptions (#13388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is tagged with that label will be merged if workflows are green dev: build-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants