user-specific file directory should show user name

.github/workflows/pr-comment.yml

@@ -76,7 +76,7 @@ jobs:
             echo "workflow_run_id=${{ github.event.workflow_run.id }}" >> $GITHUB_OUTPUT
           fi
 
-      - name: Check if PR has 'dev: no-bot-comments' label
+      - name:Check if PR has 'dev: no-bot-comments' label
         if: ${{ github.event_name == 'workflow_dispatch' || (steps.read-pr_number.outputs.pr_number != '' && steps.isCrossRepository.outputs.isCrossRepository == 'true') }}
         id: check-label
         run: |

CHANGELOG.md

@@ -102,6 +102,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added path validation to file directories in library properties dialog. [#11840](https://github.com/JabRef/jabref/issues/11840)
 - We now support usage of custom CSL styles in the Open/LibreOffice integration. [#12337](https://github.com/JabRef/jabref/issues/12337)
 - We added support for citation-only CSL styles which don't specify bibliography formatting. [#12996](https://github.com/JabRef/jabref/pull/12996)
+- We added tooltips to the "User-specific file directory" and "LaTeX file directory" fields of the library properties window. [#12269](https://github.com/JabRef/jabref/issues/12269)
 
 ### Changed
 

jabgui/src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java

@@ -15,6 +15,7 @@
 import org.jabref.gui.util.IconValidationDecorator;
 import org.jabref.gui.util.ViewModelListCellFactory;
 import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.os.OS;
 import org.jabref.logic.preferences.CliPreferences;
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.database.BibDatabaseMode;
@@ -41,6 +42,8 @@ public class GeneralPropertiesView extends AbstractPropertiesTabView<GeneralProp
     @FXML private Tooltip libSpecificFileDirSwitchTooltip;
     @FXML private Tooltip userSpecificFileDirSwitchTooltip;
     @FXML private Tooltip laTexSpecificFileDirSwitchTooltip;
+    @FXML private Tooltip userSpecificFileDirectoryTooltip;
+    @FXML private Tooltip laTexFileDirectoryTooltip;
 
     private final ControlsFxVisualizer librarySpecificFileDirectoryValidationVisualizer = new ControlsFxVisualizer();
     private final ControlsFxVisualizer userSpecificFileDirectoryValidationVisualizer = new ControlsFxVisualizer();
@@ -108,6 +111,19 @@ public void initialize() {
             laTexSpecificFileDirSwitchTooltip.setText(isAbsolute ? switchToRelativeText : switchToAbsoluteText);
         });
 
+        String userHost = preferences.getUsername() + "@" + preferences.getHostname();
+        String userDir = viewModel.userSpecificFileDirectoryProperty().get();
+        if (userDir.isEmpty()) {
+            userSpecificFileDirectoryTooltip.setText(Localization.lang("User-specific file directory: (not set)"));
+        } else {
+            userSpecificFileDirectoryTooltip.setText(Localization.lang("User-specific file directory: %0", userHost));
+        }
+        laTexFileDirectoryTooltip.textProperty().bind(
+                viewModel.laTexFileDirectoryProperty().map(path ->
+                        Localization.lang(path.isEmpty() ? "Directory for LaTeX files: (not set)" : "Directory for LaTeX files: %0", path)
+                )
+        );
+
         Platform.runLater(() -> {
             librarySpecificFileDirectoryValidationVisualizer.initVisualization(viewModel.librarySpecificFileDirectoryStatus(), librarySpecificFileDirectory);
             userSpecificFileDirectoryValidationVisualizer.initVisualization(viewModel.userSpecificFileDirectoryStatus(), userSpecificFileDirectory);

jabgui/src/main/resources/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml

@@ -57,11 +57,15 @@
             </tooltip>
         </Button>
 
+        <fx:define>
+            <Tooltip fx:id="userSpecificFileDirectoryTooltip"/>
+        </fx:define>
         <Label text="%User-specific file directory"
-               GridPane.columnIndex="0" GridPane.rowIndex="2"/>
+               GridPane.columnIndex="0" GridPane.rowIndex="2"
+               tooltip="$userSpecificFileDirectoryTooltip"/>
         <TextField fx:id="userSpecificFileDirectory"
-                   GridPane.columnIndex="1" GridPane.rowIndex="2"/>
-        <Button fx:id="userSpecificFileDirSwitchId" onAction="#userSpecificFileDirPathSwitch"
+                   GridPane.columnIndex="1" GridPane.rowIndex="2" tooltip="$userSpecificFileDirectoryTooltip"/>
+        <Button fx:id="userSpecificFileDirSwitchId" onAction="#browseUserSpecificFileDirectory"
                 styleClass="icon-button,narrow" prefHeight="20.0" prefWidth="20.0"
                 GridPane.columnIndex="2" GridPane.rowIndex="2">
             <graphic>
@@ -82,11 +86,15 @@
             </tooltip>
         </Button>
 
+        <fx:define>
+            <Tooltip fx:id="laTexFileDirectoryTooltip"/>
+        </fx:define>
         <Label text="%LaTeX file directory"
-               GridPane.columnIndex="0" GridPane.rowIndex="3"/>
+               GridPane.columnIndex="0" GridPane.rowIndex="3"
+               tooltip="$laTexFileDirectoryTooltip"/>
         <TextField fx:id="laTexFileDirectory"
-                   GridPane.columnIndex="1" GridPane.rowIndex="3"/>
-        <Button fx:id="laTexSpecificFileDirSwitchId" onAction="#laTexSpecificFileDirPathSwitch"
+                   GridPane.columnIndex="1" GridPane.rowIndex="3" tooltip="$laTexFileDirectoryTooltip"/>
+        <Button fx:id="laTexSpecificFileDirSwitchId" onAction="#browseLatexFileDirectory"
                 styleClass="icon-button,narrow" prefHeight="20.0" prefWidth="20.0"
                 GridPane.columnIndex="2" GridPane.rowIndex="3">
             <graphic>

jablib/src/main/java/org/jabref/logic/preferences/CliPreferences.java

@@ -28,38 +28,41 @@
 import org.jabref.logic.protectedterms.ProtectedTermsPreferences;
 import org.jabref.logic.remote.RemotePreferences;
 import org.jabref.logic.search.SearchPreferences;
+import org.jabref.logic.util.UserAndHost;
 import org.jabref.logic.util.io.AutoLinkPreferences;
 import org.jabref.logic.xmp.XmpPreferences;
 import org.jabref.model.entry.BibEntryPreferences;
 import org.jabref.model.entry.BibEntryTypesManager;
 
 public interface CliPreferences {
-    void clear() throws BackingStoreException;
 
+    void clear() throws BackingStoreException;
     void deleteKey(String key) throws IllegalArgumentException;
-
     void flush();
-
     void exportPreferences(Path file) throws JabRefException;
-
     void importPreferences(Path file) throws JabRefException;
 
-    InternalPreferences getInternalPreferences();
 
-    BibEntryPreferences getBibEntryPreferences();
+    UserAndHost getUserAndHost();
 
-    JournalAbbreviationPreferences getJournalAbbreviationPreferences();
+    /** Shortcut for getUserAndHost().getUser() */
+    default String getUsername() {
+        return getUserAndHost().getUser();
+    }
 
-    FilePreferences getFilePreferences();
+    /** Shortcut for getUserAndHost().getHost() */
+    default String getHostname() {
+        return getUserAndHost().getHost();
+    }
 
+    InternalPreferences getInternalPreferences();
+    BibEntryPreferences getBibEntryPreferences();
+    JournalAbbreviationPreferences getJournalAbbreviationPreferences();
+    FilePreferences getFilePreferences();
     FieldPreferences getFieldPreferences();
-
     Map<String, Object> getPreferences();
-
     Map<String, Object> getDefaults();
-
     LayoutFormatterPreferences getLayoutFormatterPreferences();
-
     ImportFormatPreferences getImportFormatPreferences();
 
     /**
@@ -68,50 +71,27 @@ public interface CliPreferences {
     SelfContainedSaveConfiguration getSelfContainedExportConfiguration();
 
     BibEntryTypesManager getCustomEntryTypesRepository();
-
     void storeCustomEntryTypesRepository(BibEntryTypesManager entryTypesManager);
-
     CleanupPreferences getCleanupPreferences();
-
     CleanupPreferences getDefaultCleanupPreset();
-
     LibraryPreferences getLibraryPreferences();
-
     DOIPreferences getDOIPreferences();
-
     OwnerPreferences getOwnerPreferences();
-
     TimestampPreferences getTimestampPreferences();
-
     RemotePreferences getRemotePreferences();
-
     ProxyPreferences getProxyPreferences();
-
     SSLPreferences getSSLPreferences();
-
     CitationKeyPatternPreferences getCitationKeyPatternPreferences();
-
     AutoLinkPreferences getAutoLinkPreferences();
-
     ExportPreferences getExportPreferences();
-
     ImporterPreferences getImporterPreferences();
-
     GrobidPreferences getGrobidPreferences();
-
     XmpPreferences getXmpPreferences();
-
     NameFormatterPreferences getNameFormatterPreferences();
-
     SearchPreferences getSearchPreferences();
-
     MrDlibPreferences getMrDlibPreferences();
-
     ProtectedTermsPreferences getProtectedTermsPreferences();
-
     AiPreferences getAiPreferences();
-
     LastFilesOpenedPreferences getLastFilesOpenedPreferences();
-
     OpenOfficePreferences getOpenOfficePreferences(JournalAbbreviationRepository journalAbbreviationRepository);
 }

jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

@@ -87,6 +87,7 @@
 import org.jabref.logic.shared.security.Password;
 import org.jabref.logic.util.BuildInfo;
 import org.jabref.logic.util.Directories;
+import org.jabref.logic.util.UserAndHost;
 import org.jabref.logic.util.Version;
 import org.jabref.logic.util.io.AutoLinkPreferences;
 import org.jabref.logic.util.io.FileHistory;
@@ -411,7 +412,7 @@ public class JabRefCliPreferences implements CliPreferences {
     /**
      * Cache variables
      */
-    private String userAndHost;
+    private UserAndHost userAndHost;
 
     private LibraryPreferences libraryPreferences;
     private DOIPreferences doiPreferences;
@@ -1456,7 +1457,7 @@ public InternalPreferences getInternalPreferences() {
                 Version.parse(get(VERSION_IGNORED_UPDATE)),
                 getBoolean(VERSION_CHECK_ENABLED),
                 getPath(PREFS_EXPORT_PATH, getDefaultPath()),
-                getUserAndHost(),
+                getUserAndHost().getString(),
                 getBoolean(MEMORY_STICK_MODE));
 
         EasyBind.listen(internalPreferences.ignoredVersionProperty(),
@@ -1480,11 +1481,14 @@ public InternalPreferences getInternalPreferences() {
         return internalPreferences;
     }
 
-    private String getUserAndHost() {
-        if (StringUtil.isNotBlank(userAndHost)) {
+    @Override
+    public UserAndHost getUserAndHost() {
+        if (userAndHost != null) {
             return userAndHost;
         }
-        userAndHost = get(DEFAULT_OWNER) + '-' + OS.getHostName();
+        String user = get(DEFAULT_OWNER);
+        String host = OS.getHostName();
+        userAndHost = new UserAndHost(user, host);
         return userAndHost;
     }
 

jablib/src/main/java/org/jabref/logic/util/UserAndHost.java

@@ -0,0 +1,25 @@
+package org.jabref.logic.util;
+
+import java.util.Objects;
+
+public class UserAndHost {
+    private final String user;
+    private final String host;
+
+    public UserAndHost(String user, String host) {
+        this.user = Objects.requireNonNull(user, "user must not be null");
+        this.host = Objects.requireNonNull(host, "host must not be null");
+    }
+
+    public String getUser() {
+        return user;
+    }
+
+    public String getHost() {
+        return host;
+    }
+
+    public String getString() {
+        return "User: " + user + ", Host: " + host;
+    }
+}