user-specific file directory should show user name

CHANGELOG.md

@@ -107,6 +107,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added path validation to file directories in library properties dialog. [#11840](https://github.com/JabRef/jabref/issues/11840)
 - We now support usage of custom CSL styles in the Open/LibreOffice integration. [#12337](https://github.com/JabRef/jabref/issues/12337)
 - We added support for citation-only CSL styles which don't specify bibliography formatting. [#12996](https://github.com/JabRef/jabref/pull/12996)
+- We added tooltips to the "User-specific file directory" and "LaTeX file directory" fields of the library properties window. [#12269](https://github.com/JabRef/jabref/issues/12269)
 
 ### Changed
 

jabgui/src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java

@@ -41,6 +41,8 @@ public class GeneralPropertiesView extends AbstractPropertiesTabView<GeneralProp
     @FXML private Tooltip libSpecificFileDirSwitchTooltip;
     @FXML private Tooltip userSpecificFileDirSwitchTooltip;
     @FXML private Tooltip laTexSpecificFileDirSwitchTooltip;
+    @FXML private Tooltip userSpecificFileDirectoryTooltip;
+    @FXML private Tooltip laTexFileDirectoryTooltip;
 
     private final ControlsFxVisualizer librarySpecificFileDirectoryValidationVisualizer = new ControlsFxVisualizer();
     private final ControlsFxVisualizer userSpecificFileDirectoryValidationVisualizer = new ControlsFxVisualizer();
@@ -108,6 +110,18 @@ public void initialize() {
             laTexSpecificFileDirSwitchTooltip.setText(isAbsolute ? switchToRelativeText : switchToAbsoluteText);
         });
 
+        String userHost = preferences.getUsername() + "@" + preferences.getHostname();
+        userSpecificFileDirectoryTooltip.setText(userHost);
+        laTexFileDirectoryTooltip.textProperty().bind(
+                viewModel.laTexFileDirectoryProperty().map(path -> {
+                    if (path.isEmpty()) {
+                        return Localization.lang("Directory for LaTeX files: (not set)");
+                    } else {
+                        return Localization.lang("Directory for LaTeX files: %0", path);
+                    }
+                })
+                );
+
         Platform.runLater(() -> {
             librarySpecificFileDirectoryValidationVisualizer.initVisualization(viewModel.librarySpecificFileDirectoryStatus(), librarySpecificFileDirectory);
             userSpecificFileDirectoryValidationVisualizer.initVisualization(viewModel.userSpecificFileDirectoryStatus(), userSpecificFileDirectory);

jabgui/src/main/resources/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml

@@ -57,11 +57,15 @@
             </tooltip>
         </Button>
 
+        <fx:define>
+            <Tooltip fx:id="userSpecificFileDirectoryTooltip"/>
+        </fx:define>
         <Label text="%User-specific file directory"
-               GridPane.columnIndex="0" GridPane.rowIndex="2"/>
+               GridPane.columnIndex="0" GridPane.rowIndex="2"
+               tooltip="$userSpecificFileDirectoryTooltip"/>
         <TextField fx:id="userSpecificFileDirectory"
-                   GridPane.columnIndex="1" GridPane.rowIndex="2"/>
-        <Button fx:id="userSpecificFileDirSwitchId" onAction="#userSpecificFileDirPathSwitch"
+                   GridPane.columnIndex="1" GridPane.rowIndex="2" tooltip="$userSpecificFileDirectoryTooltip"/>
+        <Button fx:id="userSpecificFileDirSwitchId" onAction="#browseUserSpecificFileDirectory"
                 styleClass="icon-button,narrow" prefHeight="20.0" prefWidth="20.0"
                 GridPane.columnIndex="2" GridPane.rowIndex="2">
             <graphic>
@@ -82,11 +86,15 @@
             </tooltip>
         </Button>
 
+        <fx:define>
+            <Tooltip fx:id="laTexFileDirectoryTooltip"/>
+        </fx:define>
         <Label text="%LaTeX file directory"
-               GridPane.columnIndex="0" GridPane.rowIndex="3"/>
+               GridPane.columnIndex="0" GridPane.rowIndex="3"
+               tooltip="$laTexFileDirectoryTooltip"/>
         <TextField fx:id="laTexFileDirectory"
-                   GridPane.columnIndex="1" GridPane.rowIndex="3"/>
-        <Button fx:id="laTexSpecificFileDirSwitchId" onAction="#laTexSpecificFileDirPathSwitch"
+                   GridPane.columnIndex="1" GridPane.rowIndex="3" tooltip="$laTexFileDirectoryTooltip"/>
+        <Button fx:id="laTexSpecificFileDirSwitchId" onAction="#browseLatexFileDirectory"
                 styleClass="icon-button,narrow" prefHeight="20.0" prefWidth="20.0"
                 GridPane.columnIndex="2" GridPane.rowIndex="3">
             <graphic>

jablib/src/main/java/org/jabref/logic/preferences/CliPreferences.java

@@ -28,12 +28,14 @@
 import org.jabref.logic.protectedterms.ProtectedTermsPreferences;
 import org.jabref.logic.remote.RemotePreferences;
 import org.jabref.logic.search.SearchPreferences;
+import org.jabref.logic.util.UserAndHost;
 import org.jabref.logic.util.io.AutoLinkPreferences;
 import org.jabref.logic.xmp.XmpPreferences;
 import org.jabref.model.entry.BibEntryPreferences;
 import org.jabref.model.entry.BibEntryTypesManager;
 
 public interface CliPreferences {
+
     void clear() throws BackingStoreException;
 
     void deleteKey(String key) throws IllegalArgumentException;
@@ -44,6 +46,18 @@ public interface CliPreferences {
 
     void importPreferences(Path file) throws JabRefException;
 
+    UserAndHost getUserAndHost();
+
+    /** Shortcut for getUserAndHost().getUser() */
+    default String getUsername() {
+        return getUserAndHost().user();
+    }
+
+    /** Shortcut for getUserAndHost().getHost() */
+    default String getHostname() {
+        return getUserAndHost().host();
+    }
+
     InternalPreferences getInternalPreferences();
 
     BibEntryPreferences getBibEntryPreferences();

jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

@@ -87,6 +87,7 @@
 import org.jabref.logic.shared.security.Password;
 import org.jabref.logic.util.BuildInfo;
 import org.jabref.logic.util.Directories;
+import org.jabref.logic.util.UserAndHost;
 import org.jabref.logic.util.Version;
 import org.jabref.logic.util.io.AutoLinkPreferences;
 import org.jabref.logic.util.io.FileHistory;
@@ -411,7 +412,7 @@ public class JabRefCliPreferences implements CliPreferences {
     /**
      * Cache variables
      */
-    private String userAndHost;
+    private UserAndHost userAndHost;
 
     private LibraryPreferences libraryPreferences;
     private DOIPreferences doiPreferences;
@@ -1456,7 +1457,7 @@ public InternalPreferences getInternalPreferences() {
                 Version.parse(get(VERSION_IGNORED_UPDATE)),
                 getBoolean(VERSION_CHECK_ENABLED),
                 getPath(PREFS_EXPORT_PATH, getDefaultPath()),
-                getUserAndHost(),
+                getUserAndHost().toString(),
                 getBoolean(MEMORY_STICK_MODE));
 
         EasyBind.listen(internalPreferences.ignoredVersionProperty(),
@@ -1480,11 +1481,14 @@ public InternalPreferences getInternalPreferences() {
         return internalPreferences;
     }
 
-    private String getUserAndHost() {
-        if (StringUtil.isNotBlank(userAndHost)) {
+    @Override
+    public UserAndHost getUserAndHost() {
+        if (userAndHost != null) {
             return userAndHost;
         }
-        userAndHost = get(DEFAULT_OWNER) + '-' + OS.getHostName();
+        String user = get(DEFAULT_OWNER);
+        String host = OS.getHostName();
+        userAndHost = new UserAndHost(user, host);
         return userAndHost;
     }
 

jablib/src/main/java/org/jabref/logic/util/UserAndHost.java

@@ -0,0 +1,3 @@
+package org.jabref.logic.util;
+public record UserAndHost(String user, String host) {
+}

jablib/src/main/resources/l10n/JabRef_en.properties

@@ -2808,6 +2808,9 @@ Pushing\ citations\ to\ TeXShop\ is\ only\ possible\ on\ macOS\!=Pushing citatio
 
 Single\ instance=Single instance
 
+Directory\ for\ LaTeX\ files\:\ %0=Directory for LaTeX files: %0
+Directory\ for\ LaTeX\ files\:\ (not\ set)=Directory for LaTeX files: (not set)
+
 Copied\ %0\ entry(s)=Copied %0 entry(s)
 Cut\ %0\ entry(s)=Cut %0 entry(s)
 Deleted\ %0\ entry(s)=Deleted %0 entry(s)