-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add monthfiled to resolve strings fields #13379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java
Show resolved
Hide resolved
One more thing: Isnt monthfield an alias for month? Isn't it then an issue regarding aliassed fields? |
jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java
Outdated
Show resolved
Hide resolved
jabgui/src/test/java/org/jabref/migrations/GuiPreferencesMigrationsTest.java
Outdated
Show resolved
Hide resolved
jabgui/src/test/java/org/jabref/migrations/GuiPreferencesMigrationsTest.java
Show resolved
Hide resolved
OMG, its filed; not field. Thus, no alias |
Yes! That's a tricky one. Had to carefully read the issue... 😆 |
jabgui/src/test/java/org/jabref/migrations/GuiPreferencesMigrationsTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With nice preference migration. Thank you!
I removed duplicate "mothfiled" in 4f1e64a
(#13379)
@trag-bot didn't find any issues in the code! ✅✨ |
Fixes #13375
Steps to test
Open JabRef settings -> Entry -> Resolve strings for -> montfiled is present
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)