-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix for issue 13234 #13283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 13234 #13283
Conversation
Your pull request conflicts with the target branch. Please merge |
new Label(Localization.lang("The selected entry doesn't have a DOI linked to it. Lookup a DOI and try again."))); | ||
|
||
Text doiLookUpText = new Text(Localization.lang("The selected entry doesn't have a DOI linked to it. ")); | ||
Hyperlink doiLookUpHyperLink = new Hyperlink(Localization.lang("Lookup a DOI and try again.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hyperlink text 'Lookup a DOI and try again.' should be sentence case, starting with a lowercase letter, to maintain consistency with other UI elements.
entry.setField(StandardField.DOI, doiIdentifier.get().asString()); | ||
searchForRelations(entry, listView, abortButton, refreshButton, searchType, importButton, progress, shouldRefresh); | ||
} else { | ||
dialogService.notify("No DOI found"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notification message 'No DOI found' should be sentence case, starting with a lowercase letter, to maintain consistency with other UI elements.
Follow-up #13285 @YaxPrajapti No need to delete branches and close PRs. Please just add new commits. In the concrete case, continue to work on |
Closes #13234
This PR enhances the "Citation relations" feature by making the "Look up a DOI and try again." text a clickable hyperlink. On clicking, the text changes to "Looking up DOI...". Based on the lookup result:
If a DOI is found, it is used for citation relations.
If no DOI is found, a notification "No DOI found" is shown and the link resets to its original state.
Steps to test
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)