feat: support open reference at semantic scholar #13278
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package org.jabref.gui.maintable; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| import javafx.beans.binding.BooleanExpression; | ||
|
|
||
| import org.jabref.gui.DialogService; | ||
| import org.jabref.gui.StateManager; | ||
| import org.jabref.gui.actions.SimpleCommand; | ||
| import org.jabref.gui.desktop.os.NativeDesktop; | ||
| import org.jabref.gui.preferences.GuiPreferences; | ||
| import org.jabref.logic.importer.ImporterPreferences; | ||
| import org.jabref.logic.l10n.Localization; | ||
| import org.jabref.logic.util.ExternalLinkCreator; | ||
| import org.jabref.model.entry.BibEntry; | ||
| import org.jabref.model.entry.field.StandardField; | ||
|
|
||
| import static org.jabref.gui.actions.ActionHelper.isFieldSetForSelectedEntry; | ||
| import static org.jabref.gui.actions.ActionHelper.needsEntriesSelected; | ||
|
|
||
| public class SearchGoogleScholarAction extends SimpleCommand { | ||
| private final DialogService dialogService; | ||
| private final StateManager stateManager; | ||
| private final GuiPreferences preferences; | ||
| private final ExternalLinkCreator externalLinkCreator; | ||
|
|
||
| public SearchGoogleScholarAction(DialogService dialogService, StateManager stateManager, GuiPreferences preferences, ImporterPreferences importerPreferences) { | ||
| this.dialogService = dialogService; | ||
| this.stateManager = stateManager; | ||
| this.preferences = preferences; | ||
| this.externalLinkCreator = new ExternalLinkCreator(importerPreferences); | ||
|
|
||
| BooleanExpression fieldIsSet = isFieldSetForSelectedEntry(StandardField.TITLE, stateManager); | ||
| this.executable.bind(needsEntriesSelected(1, stateManager).and(fieldIsSet)); | ||
| } | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| stateManager.getActiveDatabase().ifPresent(databaseContext -> { | ||
| final List<BibEntry> bibEntries = stateManager.getSelectedEntries(); | ||
|
|
||
| if (bibEntries.size() != 1) { | ||
| dialogService.notify(Localization.lang("This operation requires exactly one item to be selected.")); | ||
|
There was a problem hiding this comment. The notification message should be in sentence case, not title case, to maintain consistency with other user interface texts. |
||
| return; | ||
| } | ||
| externalLinkCreator.getGoogleScholarSearchURL(bibEntries.getFirst()).ifPresent(url -> { | ||
|
There was a problem hiding this comment. The method getGoogleScholarSearchURL should not return null. It should return an Optional to avoid null checks and improve code safety. |
||
| try { | ||
| NativeDesktop.openExternalViewer(databaseContext, preferences, url, StandardField.URL, dialogService, bibEntries.getFirst()); | ||
| } catch (IOException ex) { | ||
|
Comment on lines
+48
to
+50
There was a problem hiding this comment. The try block covers too many statements. It should be minimized to cover only the statement that might throw the IOException. |
||
| dialogService.showErrorDialogAndWait(Localization.lang("Unable to open Google Scholar."), ex); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package org.jabref.gui.maintable; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| import javafx.beans.binding.BooleanExpression; | ||
|
|
||
| import org.jabref.gui.DialogService; | ||
| import org.jabref.gui.StateManager; | ||
| import org.jabref.gui.actions.SimpleCommand; | ||
| import org.jabref.gui.desktop.os.NativeDesktop; | ||
| import org.jabref.gui.preferences.GuiPreferences; | ||
| import org.jabref.logic.importer.ImporterPreferences; | ||
| import org.jabref.logic.l10n.Localization; | ||
| import org.jabref.logic.util.ExternalLinkCreator; | ||
| import org.jabref.model.entry.BibEntry; | ||
| import org.jabref.model.entry.field.StandardField; | ||
|
|
||
| import static org.jabref.gui.actions.ActionHelper.isFieldSetForSelectedEntry; | ||
| import static org.jabref.gui.actions.ActionHelper.needsEntriesSelected; | ||
|
|
||
| public class SearchSemanticScholarAction extends SimpleCommand { | ||
| private final DialogService dialogService; | ||
| private final StateManager stateManager; | ||
| private final GuiPreferences preferences; | ||
| private final ExternalLinkCreator externalLinkCreator; | ||
|
|
||
| public SearchSemanticScholarAction(DialogService dialogService, StateManager stateManager, GuiPreferences preferences, ImporterPreferences importerPreferences) { | ||
| this.dialogService = dialogService; | ||
| this.stateManager = stateManager; | ||
| this.preferences = preferences; | ||
| this.externalLinkCreator = new ExternalLinkCreator(importerPreferences); | ||
|
|
||
| BooleanExpression fieldIsSet = isFieldSetForSelectedEntry(StandardField.TITLE, stateManager); | ||
| this.executable.bind(needsEntriesSelected(1, stateManager).and(fieldIsSet)); | ||
| } | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| stateManager.getActiveDatabase().ifPresent(databaseContext -> { | ||
| final List<BibEntry> bibEntries = stateManager.getSelectedEntries(); | ||
|
|
||
| if (bibEntries.size() != 1) { | ||
| dialogService.notify(Localization.lang("This operation requires exactly one item to be selected.")); | ||
|
There was a problem hiding this comment. The notification message should be in sentence case, not title case, to maintain consistency with other user interface texts. There was a problem hiding this comment. The notification message should be in sentence case, not title case, to maintain consistency with other user interface texts. |
||
| return; | ||
| } | ||
| externalLinkCreator.getSemanticScholarSearchURL(bibEntries.getFirst()).ifPresent(url -> { | ||
| try { | ||
| NativeDesktop.openExternalViewer(databaseContext, preferences, url, StandardField.URL, dialogService, bibEntries.getFirst()); | ||
| } catch (IOException ex) { | ||
|
Comment on lines
+48
to
+50
There was a problem hiding this comment. The try block covers too many statements. It should be minimized to only cover the statement that might throw the IOException. |
||
| dialogService.showErrorDialogAndWait(Localization.lang("Unable to open Semantic Scholar."), ex); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package org.jabref.gui.preferences.websearch; | ||
|
|
||
| import javafx.beans.property.SimpleStringProperty; | ||
| import javafx.beans.property.StringProperty; | ||
|
|
||
| public class SearchEngineItem { | ||
| private final StringProperty name; | ||
| private final StringProperty urlTemplate; | ||
|
|
||
| public SearchEngineItem(String name, String urlTemplate) { | ||
| this.name = new SimpleStringProperty(name); | ||
| this.urlTemplate = new SimpleStringProperty(urlTemplate); | ||
| } | ||
|
|
||
| public StringProperty nameProperty() { | ||
| return name; | ||
| } | ||
|
|
||
| public StringProperty urlTemplateProperty() { | ||
| return urlTemplate; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name.get(); | ||
| } | ||
|
|
||
| public String getUrlTemplate() { | ||
| return urlTemplate.get(); | ||
| } | ||
|
|
||
| public void setUrlTemplate(String urlTemplate) { | ||
| this.urlTemplate.set(urlTemplate); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new string 'Search Google Scholar' should be consistent with existing strings and grouped semantically with similar search actions.