fix: resolve static analysis issues in code

jabgui/src/main/java/org/jabref/Launcher.java

@@ -105,7 +105,7 @@ public static void initLogging(String[] args) {
 
         // We must configure logging as soon as possible, which is why we cannot wait for the usual
         // argument parsing workflow to parse logging options e.g. --debug
-        boolean isDebugEnabled = Arrays.stream(args).anyMatch(arg -> "--debug".equalsIgnoreCase(arg));
+        boolean isDebugEnabled = Arrays.stream(args).anyMatch("--debug"::equalsIgnoreCase);
 
         // addLogToDisk
         // We cannot use `Injector.instantiateModelOrService(BuildInfo.class).version` here, because this initializes logging

jabgui/src/main/java/org/jabref/gui/autocompleter/PersonNameStringConverter.java

@@ -28,8 +28,8 @@ public PersonNameStringConverter(AutoCompletePreferences preferences) {
                 autoCompFF = false;
                 autoCompLF = true;
                 break;
-            default:
             case BOTH:
+            default:
                 autoCompFF = true;
                 autoCompLF = true;
                 break;
@@ -42,24 +42,20 @@ public PersonNameStringConverter(AutoCompletePreferences preferences) {
     public String toString(Author author) {
         if (autoCompLF) {
             switch (autoCompleteFirstNameMode) {
-                case ONLY_ABBREVIATED:
+                case ONLY_ABBREVIATED, BOTH:
                     return author.getFamilyGiven(true);
                 case ONLY_FULL:
                     return author.getFamilyGiven(false);
-                case BOTH:
-                    return author.getFamilyGiven(true);
                 default:
                     break;
             }
         }
         if (autoCompFF) {
             switch (autoCompleteFirstNameMode) {
-                case ONLY_ABBREVIATED:
+                case ONLY_ABBREVIATED, BOTH:
                     return author.getGivenFamily(true);
                 case ONLY_FULL:
                     return author.getGivenFamily(false);
-                case BOTH:
-                    return author.getGivenFamily(true);
                 default:
                     break;
             }

jabgui/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternSuggestionCell.java

@@ -74,14 +74,14 @@ public CitationKeyPatternSuggestionTextField(List<String> citationKeyPatterns) {
         }
 
         private void setListener() {
-            textProperty().addListener((observable, oldValue, newValue) -> {
+            textProperty().addListener((_, _, _) -> {
                 String enteredText = getText();
                 if (enteredText == null || enteredText.isEmpty()) {
                     suggestionsList.hide();
                 } else {
                     List<String> filteredEntries = citationKeyPatterns.stream()
                                                                       .filter(e -> e.toLowerCase().contains(enteredText.toLowerCase()))
-                                                                      .collect(Collectors.toList());
+                                                                      .toList();
 
                     if (!filteredEntries.isEmpty()) {
                         populatePopup(filteredEntries);
@@ -96,9 +96,7 @@ private void setListener() {
                 }
             });
 
-            focusedProperty().addListener((observable, oldValue, newValue) -> {
-                suggestionsList.hide();
-            });
+            focusedProperty().addListener((_, _, _) -> suggestionsList.hide());
         }
 
         private void populatePopup(List<String> searchResult) {
@@ -119,7 +117,7 @@ private void populatePopup(List<String> searchResult) {
 
                 menuItems.add(item);
 
-                item.setOnAction(actionEvent -> {
+                item.setOnAction(_ -> {
                     setText(result);
                     positionCaret(result.length());
                     suggestionsList.hide();

jabgui/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java

@@ -1,7 +1,6 @@
 package org.jabref.gui.commonfxcontrols;
 
 import java.util.List;
-import java.util.stream.Collectors;
 
 import javax.swing.undo.UndoManager;
 

jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckDialog.java

@@ -87,11 +87,10 @@ public void initialize() {
                 message.message().getFirst().equals(viewModel.selectedEntryTypeProperty().get())
         );
 
-        viewModel.selectedEntryTypeProperty().addListener((obs, oldValue, newValue) -> {
-            filteredData.setPredicate(message ->
-                    message.message().getFirst().equals(newValue)
-            );
-        });
+        viewModel.selectedEntryTypeProperty().addListener((_, _, newValue) ->
+                filteredData.setPredicate(message ->
+                        message.message().getFirst().equals(newValue)
+        ));
 
         tableView.setItems(filteredData);
 

jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckDialogViewModel.java

@@ -45,7 +45,8 @@
 
 public class ConsistencyCheckDialogViewModel extends AbstractViewModel {
 
-    private final Logger LOGGER = LoggerFactory.getLogger(ConsistencyCheckDialogViewModel.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ConsistencyCheckDialogViewModel.class);
+    private static final int EXTRA_COLUMNS_COUNT = 2;
 
     private final BibliographyConsistencyCheck.Result result;
     private final DialogService dialogService;
@@ -54,7 +55,6 @@ public class ConsistencyCheckDialogViewModel extends AbstractViewModel {
 
     private final List<Field> allReportedFields;
     private final int columnCount;
-    private final int EXTRA_COLUMNS_COUNT = 2;
     private final ObservableList<ConsistencyMessage> tableData = FXCollections.observableArrayList();
     private final StringProperty selectedEntryType = new SimpleStringProperty();
 
@@ -85,9 +85,7 @@ public StringProperty selectedEntryTypeProperty() {
 
     public List<String> getEntryTypes() {
         List<String> entryTypes = new ArrayList<>();
-        result.entryTypeToResultMap().forEach((entrySet, entryTypeResult) -> {
-            entryTypes.add(entrySet.toString());
-        });
+        result.entryTypeToResultMap().forEach((entrySet, _) -> entryTypes.add(entrySet.toString()));
         return entryTypes;
     }
 
@@ -96,7 +94,7 @@ public ObservableList<ConsistencyMessage> getTableData() {
     }
 
     public Set<String> getColumnNames() {
-        Set<String> result = new LinkedHashSet<>(columnCount + EXTRA_COLUMNS_COUNT);
+        Set<String> result = LinkedHashSet.newLinkedHashSet(columnCount + EXTRA_COLUMNS_COUNT);
         result.add("Entry Type");
         result.add("CitationKey");
         allReportedFields.forEach(field-> result.add(field.getDisplayName().trim()));
@@ -124,12 +122,12 @@ private void writeMapEntry(Map.Entry<EntryType, BibliographyConsistencyCheck.Ent
         BibliographyConsistencyCheck.EntryTypeResult entries = mapEntry.getValue();
         SequencedCollection<BibEntry> bibEntries = entries.sortedEntries();
 
-        bibEntries.forEach(Unchecked.consumer(bibEntry -> {
-            writeBibEntry(bibEntry, entryType, requiredFields, optionalFields);
-        }));
+        bibEntries.forEach(Unchecked.consumer(bibEntry ->
+            writeBibEntry(bibEntry, entryType, requiredFields, optionalFields)
+        ));
     }
 
-    private void writeBibEntry(BibEntry bibEntry, String entryType, Set<Field> requiredFields, Set<Field> optionalFields) throws IOException {
+    private void writeBibEntry(BibEntry bibEntry, String entryType, Set<Field> requiredFields, Set<Field> optionalFields) {
         List<String> theRecord = getFindingsAsList(bibEntry, entryType, requiredFields, optionalFields);
         List<String> message = new ArrayList<>();
         for (String s: theRecord) {
@@ -143,7 +141,7 @@ private List<String> getFindingsAsList(BibEntry bibEntry, String entryType, Set<
         List<String> result = new ArrayList<>(columnCount + EXTRA_COLUMNS_COUNT);
         result.add(entryType);
         result.add(bibEntry.getCitationKey().orElse(""));
-        allReportedFields.forEach(field -> {
+        allReportedFields.forEach(field ->
             result.add(bibEntry.getField(field).map(_ -> {
                 if (requiredFields.contains(field)) {
                     return ConsistencySymbol.REQUIRED_FIELD_AT_ENTRY_TYPE_CELL_ENTRY.getText();
@@ -152,8 +150,8 @@ private List<String> getFindingsAsList(BibEntry bibEntry, String entryType, Set<
                 } else {
                     return ConsistencySymbol.UNKNOWN_FIELD_AT_ENTRY_TYPE_CELL_ENTRY.getText();
                 }
-            }).orElse(ConsistencySymbol.UNSET_FIELD_AT_ENTRY_TYPE_CELL_ENTRY.getText()));
-        });
+            }).orElse(ConsistencySymbol.UNSET_FIELD_AT_ENTRY_TYPE_CELL_ENTRY.getText()))
+        );
         return result;
     }
 

jabgui/src/main/java/org/jabref/gui/edit/EditAction.java

@@ -72,7 +72,6 @@ public void execute() {
                 }
             } else if ((focusOwner instanceof CodeArea) || (focusOwner instanceof WebView)) {
                 LOGGER.debug("Ignoring request in CodeArea or WebView");
-                return;
             } else {
                 LOGGER.debug("Else: {}", focusOwner.getClass().getSimpleName());
                 // Not sure what is selected -> copy/paste/cut selected entries except for Preview and CodeArea

jabgui/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java

@@ -194,11 +194,11 @@ private Optional<Path> askForSavePath() {
             // Workaround for linux systems not adding file extension
             if (!savePath.getFileName().toString().toLowerCase().endsWith(".bib")) {
                 savePath = Path.of(savePath.toString() + ".bib");
-                if (!Files.notExists(savePath)) {
-                    if (!dialogService.showConfirmationDialogAndWait(Localization.lang("Overwrite file"), Localization.lang("'%0' exists. Overwrite file?", savePath.getFileName()))) {
+                if (!Files.notExists(savePath) && !dialogService.showConfirmationDialogAndWait(Localization.lang("Overwrite file"),
+                        Localization.lang("'%0' exists. Overwrite file?", savePath.getFileName()))) {
                         return Optional.empty();
                     }
-                }
+
                 selectedPath = Optional.of(savePath);
             }
         }
@@ -246,7 +246,7 @@ private boolean save(Path targetPath, SaveDatabaseMode mode) {
             dialogService.notify(Localization.lang("Library saved"));
             return success;
         } catch (SaveException ex) {
-            LOGGER.error("A problem occurred when trying to save the file %s".formatted(targetPath), ex);
+            LOGGER.error("A problem occurred when trying to save the file {}", targetPath, ex);
             dialogService.showErrorDialogAndWait(Localization.lang("Save library"), Localization.lang("Could not save file."), ex);
             return false;
         } finally {
@@ -307,7 +307,8 @@ private void saveWithDifferentEncoding(Path file, boolean selectedOnly, Charset
                 .filter(buttonType -> buttonType.equals(tryDifferentEncoding))
                 .isPresent();
         if (saveWithDifferentEncoding) {
-            Optional<Charset> newEncoding = dialogService.showChoiceDialogAndWait(Localization.lang("Save library"), Localization.lang("Select new encoding"), Localization.lang("Save library"), encoding, Encodings.getCharsets());
+            Optional<Charset> newEncoding = dialogService.showChoiceDialogAndWait(Localization.lang("Save library"), Localization.lang("Select new encoding"),
+                    Localization.lang("Save library"), encoding, Encodings.getCharsets());
             if (newEncoding.isPresent()) {
                 // Make sure to remember which encoding we used.
                 libraryTab.getBibDatabaseContext().getMetaData().setEncoding(newEncoding.get(), ChangePropagation.DO_NOT_POST_EVENT);

jabgui/src/main/java/org/jabref/gui/externalfiles/ChainedFilters.java

@@ -17,6 +17,7 @@ public class ChainedFilters implements DirectoryStream.Filter<Path> {
 
     private DirectoryStream.Filter<Path>[] filters;
 
+    @SafeVarargs
     public ChainedFilters(DirectoryStream.Filter<Path>... filters) {
         this.filters = filters;
     }

jabgui/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawler.java

@@ -2,6 +2,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.DirectoryStream;
 import java.nio.file.DirectoryStream.Filter;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -91,7 +92,8 @@ FileNodeViewModel searchDirectory(Path directory, UnlinkedPDFFileFilter unlinked
         //   2. GitIgnoreFilter
         ChainedFilters filters = new ChainedFilters(unlinkedPDFFileFilter, new GitIgnoreFileFilter(directory));
         Map<Boolean, List<Path>> directoryAndFilePartition;
-        try (Stream<Path> filesStream = StreamSupport.stream(Files.newDirectoryStream(directory, filters).spliterator(), false)) {
+        try (DirectoryStream<Path> dirStream = Files.newDirectoryStream(directory, filters);
+             Stream<Path> filesStream = StreamSupport.stream(dirStream.spliterator(), false)) {
             directoryAndFilePartition = filesStream.collect(Collectors.partitioningBy(Files::isDirectory));
         } catch (IOException e) {
             LOGGER.error("Error while searching files", e);
@@ -136,7 +138,7 @@ FileNodeViewModel searchDirectory(Path directory, UnlinkedPDFFileFilter unlinked
         // create and add FileNodeViewModel to the FileNodeViewModel for the current directory
         fileNodeViewModelForCurrentDirectory.getChildren().addAll(resultingFiles.stream()
                 .map(FileNodeViewModel::new)
-                .collect(Collectors.toList()));
+                .toList());
 
         return fileNodeViewModelForCurrentDirectory;
     }

jabgui/src/main/java/org/jabref/gui/fieldeditors/KeywordsEditor.java

@@ -142,7 +142,7 @@ public KeywordsEditor(Field field,
             KeyBindingRepository keyBindingRepository = Injector.instantiateModelOrService(KeyBindingRepository.class);
 
             if (keyBindingRepository.checkKeyCombinationEquality(KeyBinding.PASTE, event)) {
-                String clipboardText = clipBoardManager.getContents();
+                String clipboardText = ClipBoardManager.getContents();
                 if (!clipboardText.isEmpty()) {
                     KeywordList keywordsList = KeywordList.parse(clipboardText, viewModel.getKeywordSeparator());
                     keywordsList.stream().forEach(keyword -> keywordTagsField.addTags(keyword));

jabgui/src/main/java/org/jabref/gui/fieldeditors/optioneditors/mapbased/MapBasedEditorViewModel.java

@@ -63,7 +63,8 @@ protected T getValueFromString(String string) {
         try {
             return (T) string;
         } catch (ClassCastException ex) {
-            LOGGER.error("Could not cast string to type %1$s. Try overriding the method in a subclass and provide a conversion from string to the concrete type %1$s".formatted(string.getClass()), ex);
+            LOGGER.error("Could not cast string to type {}. Try overriding the method in a subclass and provide a conversion from string to the concrete type {}",
+                    string.getClass(), string.getClass(), ex);
         }
         return null;
     }