Skip to content

Fix macOS-14 gradlew :jabgui:run #13232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

Fix macOS-14 gradlew :jabgui:run #13232

merged 3 commits into from
Jun 3, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 2, 2025

Follow-up to #13112

Applies fix of Jendrik #13112 (comment)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added dev: binaries Binary builds should be uploaded to builds.jabref.org platform: macos labels Jun 2, 2025
Copy link
Collaborator

@jjohannes jjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix should be this: #13112 (comment)

@calixtus
Copy link
Member

calixtus commented Jun 3, 2025

Submodules have been committed

@Siedlerchr
Copy link
Member

related issue #13205 (comment)

@koppor
Copy link
Member Author

koppor commented Jun 3, 2025

related issue #13205 (comment)

Yeah, but that one is #nixOS, which is special in all matters. The aim here is to get it running in your machine 😅

@Siedlerchr
Copy link
Member

I had the same error when I used build. Will try later

@jjohannes
Copy link
Collaborator

Please also update the packaging plugin to 1.0.1 and test that assemble (and build?) work. If they worked before the change in #13112.

#13205 (comment)

Copy link

trag-bot bot commented Jun 3, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr
Copy link
Member

Seems to work now, also build works with the updated version 1.0.1 of your plugin

@Siedlerchr Siedlerchr enabled auto-merge June 3, 2025 10:32
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

The build of this PR is available at https://builds.jabref.org/pull/13232/merge.

Merged via the queue into main with commit 5dfa8e7 Jun 3, 2025
48 of 50 checks passed
@Siedlerchr Siedlerchr deleted the fix-platform branch June 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: binaries Binary builds should be uploaded to builds.jabref.org platform: macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants