Skip to content

Prepare: Enable gradle configuration cache #13212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 2, 2025
Merged

Prepare: Enable gradle configuration cache #13212

merged 14 commits into from
Jun 2, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 1, 2025

Follow-up to #13112

Prepres enabling of gradle's configuration cache.


I finally managed w/ ChatGPT and manual chain-of-thought to rewrite it. (Junie, Claude and ChatGPT could not help yesterday)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 1, 2025
@koppor koppor changed the title Remove unused variable and empty line Replace XJC plugin by bjornvester/xjc-gradle-plugin Jun 1, 2025
@koppor koppor changed the title Replace XJC plugin by bjornvester/xjc-gradle-plugin Enable gradle configuration cache Jun 2, 2025
Siedlerchr
Siedlerchr previously approved these changes Jun 2, 2025
@Siedlerchr
Copy link
Member

  • Task :jabgui:prepareMergedJarsDir of type org.beryx.jlink.PrepareMergedJarsDirTask: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.

If I remmeber correctly there is somehow a way to disable it for a single task

@koppor koppor changed the title Enable gradle configuration cache Preapre: Enable gradle configuration cache Jun 2, 2025
@koppor
Copy link
Member Author

koppor commented Jun 2, 2025

Tweaks result in

Cannot retrieve Java toolchain: org.gradle.api.UnknownDomainObjectException: Extension of type 'JavaPluginExtension' does not exist. Currently registered extension types: [ExtraPropertiesExtension]

Copy link

trag-bot bot commented Jun 2, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Jun 2, 2025
@koppor koppor enabled auto-merge June 2, 2025 10:27
@koppor koppor added this pull request to the merge queue Jun 2, 2025
@koppor koppor changed the title Preapre: Enable gradle configuration cache Prepare: Enable gradle configuration cache Jun 2, 2025
Merged via the queue into main with commit 66b90d2 Jun 2, 2025
52 of 64 checks passed
@koppor koppor deleted the refine-gradlex branch June 2, 2025 11:01
Siedlerchr added a commit to brandon-lau0/jabref that referenced this pull request Jun 2, 2025
…or-test

* upstream/main: (102 commits)
  Try to fix output
  Improve AI preferences UI and templates (JabRef#13202)
  Bump jablib/src/main/abbrv.jabref.org from `6926b83` to `333c2f1` (JabRef#13216)
  Bump jablib/src/main/resources/csl-styles from `8a2317a` to `c3df987` (JabRef#13215)
  Fixed search result focus handling (JabRef#13174)
  New Crowdin updates (JabRef#13214)
  Add Pseudonymization to CLI (JabRef#13158)
  Try parallel gource build
  Update gource.yml
  Fix position of checkout
  Preapre: Enable gradle configuration cache (JabRef#13212)
  Add yml as YAML extension (JabRef#13213)
  Fix wrong detection of issue numbers (JabRef#13211)
  Miscellaneous refactoring - II (JabRef#13197)
  Run Windows tests only on main (and on demand) (JabRef#13210)
  Fix porcelain for consistency check (JabRef#13209)
  Use setup-jbang action (instead of custom call of .sh script) (JabRef#13208)
  Add link to JabRef guru (JabRef#13207)
  Switch to gradlex for modularity (JabRef#13112)
  feat(ci-cd): change issue URL pattern (JabRef#13206)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is tagged with that label will be merged if workflows are green status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants