-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
CheckoutPR: Add support for updating main #13195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
if (pr.isMerged()) { | ||
System.out.println("Pull request is already merged - checking out main branch..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using exclamation marks at the end of a sentence. They are more for screaming. Use a dot to end the sentence.
} | ||
|
||
if (pr.getState().equals(GHIssueState.CLOSED)) { | ||
System.out.println("Warning: Pull request is closed. Trying to continue nevertheless."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using exclamation marks at the end of a sentence. They are more for screaming. Use a dot to end the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny questions/comments on uniformity
update - found a comment in the file, can ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think usage of the command line pgm calls is intended, if we want the verbose git outputs on CLI, so looks good to me.
Wished at JabRef/blog.jabref.org#115 (comment)
Works:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)