Skip to content

CheckoutPR: Add support for updating main #13195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

CheckoutPR: Add support for updating main #13195

merged 2 commits into from
May 31, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented May 30, 2025

Wished at JabRef/blog.jabref.org#115 (comment)

Works:

image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

}

if (pr.isMerged()) {
System.out.println("Pull request is already merged - checking out main branch...");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using exclamation marks at the end of a sentence. They are more for screaming. Use a dot to end the sentence.

}

if (pr.getState().equals(GHIssueState.CLOSED)) {
System.out.println("Warning: Pull request is closed. Trying to continue nevertheless.");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using exclamation marks at the end of a sentence. They are more for screaming. Use a dot to end the sentence.

Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny questions/comments on uniformity
update - found a comment in the file, can ignore.

Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think usage of the command line pgm calls is intended, if we want the verbose git outputs on CLI, so looks good to me.

@koppor koppor added this pull request to the merge queue May 31, 2025
Merged via the queue into main with commit c1e726b May 31, 2025
2 checks passed
@koppor koppor deleted the add-run-main branch May 31, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants