Skip to content

Add gg to .gitignore #13152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

Add gg to .gitignore #13152

merged 5 commits into from
May 20, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented May 19, 2025

For interested users, it should be easy to run PRs or the main version. With gg.cmd, this is now very easy:

./gg.cmd gradle :jabgui:run

Works on macOS, Linux, and Windows.

Screenshot from Windows:

image

Needed to add m2 to .gitignore - eirikb/gg#69


This is the alternative to #13039 - and I tend to like gg more than mise, because gg does not require any installation, but mise does.

gg.cmd could also be on the PATH, but that would require some additional step by the user, which we want to avoid.


  • Good, because "anyone" can run gradle (without the requirement of JDK installation)
  • Bad, because we have a kind of a binary in the repository

Follow-up-Tasks:

  • Update "nerd" hints -> meaning: how to run jabref using gradle without JDK on the command line. "bootstrap"

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as ready for review May 19, 2025 20:59
@koppor
Copy link
Member Author

koppor commented May 20, 2025

Users could have gg.cmd on their PATH. eirikb/gg#77. They could also download locally.

Thus the task is to add gg.cmd to .gitignore 😅

@koppor koppor changed the title [experiment] Use gg Add gg to .gitignore May 20, 2025
@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label May 20, 2025
@koppor koppor enabled auto-merge May 20, 2025 11:18
Copy link

trag-bot bot commented May 20, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 2340398 May 20, 2025
2 checks passed
@koppor koppor deleted the add-gg branch May 20, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PR is tagged with that label will be merged if workflows are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants