Fix citation key table #13151
Merged
Fix citation key table #13151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Christoph <siedlerkiller@gmail.com>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
...va/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckResultTxtWriterTest.java
Outdated
Show resolved
Hide resolved
...n/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckResultTxtWriter.java
Show resolved
Hide resolved
| return fieldComparison; | ||
| } | ||
| } | ||
| assert !it1.hasNext() && !it2.hasNext(); |
There was a problem hiding this comment.
Using assertions for control flow is not recommended as they can be disabled at runtime, leading to unexpected behavior. Consider using a different approach to ensure iterators are exhausted.
| return 1; | ||
| } | ||
|
|
||
| assert e1HasCitationKey && e2HasCitationKey; |
There was a problem hiding this comment.
Using assertions for control flow is not recommended as they can be disabled at runtime. Consider using a more robust method to ensure both entries have citation keys.
koppor
added
the
status: ready-for-review
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13013
No CHANGELOG, because feature is not yet released
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)