Try to fix FileNotFoundException on selecting default JStyles
#13075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhramit <subhramit.bb@live.in>
|
@trag-bot didn't find any issues in the code! ✅✨ |
subhramit
changed the title
FileNotFoundException on selecting default JStyle
subhramit
added
the
status: ready-for-review
subhramit
changed the title
FileNotFoundException on selecting default JStyleFileNotFoundException on selecting default JStyles
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
May 7, 2025
koppor
reviewed
May 8, 2025
Comment on lines
+280
to
+282
| URL resUrl = JStyle.class.getResource(path); | ||
| if (resUrl != null) { | ||
| try (InputStream stream = resUrl.openStream()) { |
There was a problem hiding this comment.
I was thinking of ...getResourceAsStream, but I had no time to experiment. Maybe at a follow-up?
We need getResourceAsStream for GraalVM - see JabRef#693
4 tasks
subhramit
added
dev: hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13073
This is an internal PR to observe any side-effects.
The issue occurs only when running via gradle, and not on installing via dmg/msi.
Description of fix based on artifact.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)