[Benchmark] Remove preparation noise from the 'validation' benchmarks #7201
+23
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
bug
Benchmarks
No Changelog Required
|
effectfully
force-pushed
the
effectfully/benchmark/remove-preparation-noise-from-validation
branch
from
cc042b0 to
de85da1
Compare
|
/benchmark validation |
3 similar comments
|
/benchmark validation |
|
/benchmark validation |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
effectfully
commented
Jul 10, 2025
| bench (dropExtension file) $ act file scriptBS | ||
| let prep = toNamedDeBruijnTerm . UPLC._progTerm . unsafeUnflat file | ||
| in env (prep <$> BS.readFile (dir </> file)) $ \(~term) -> | ||
| bench (dropExtension file) $ act term |
There was a problem hiding this comment.
Note that this doesn't address the issue of term being deep-forced by benchTermCek, which also is unnecessarily counted in.
There was a problem hiding this comment.
Do you intend to address the issue in this PR ?
There was a problem hiding this comment.
No, that's for #7201. I'll also write documentation there, this PR is just to fix the very specific issue of the validation benchmarks.
|
Comparing benchmark results of 'validation' on '589516f72' (base) and 'de85da1c4' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '589516f72' (base) and 'de85da1c4' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '589516f72' (base) and 'de85da1c4' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '589516f72' (base) and 'de85da1c4' (PR) Results table
|
effectfully
force-pushed
the
effectfully/benchmark/remove-preparation-noise-from-validation
branch
from
de85da1 to
5f0b15a
Compare
|
/benchmark validation |
1 similar comment
|
/benchmark validation |
|
/benchmark validation-full |
1 similar comment
|
/benchmark validation-full |
|
/benchmark validation-decode |
1 similar comment
|
/benchmark validation-decode |
|
/benchmark validation |
1 similar comment
|
/benchmark validation |
|
/benchmark validation-agda-cek |
1 similar comment
|
/benchmark validation-agda-cek |
|
/benchmark validation-full |
1 similar comment
|
/benchmark validation-full |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
/benchmark validation-agda-cek |
3 similar comments
|
/benchmark validation-agda-cek |
|
/benchmark validation-agda-cek |
|
/benchmark validation-agda-cek |
|
Comparing benchmark results of 'validation-full' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-full' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-agda-cek' on '5bdbb8df36' (base) and '59e21e830d' (PR) Results table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
validationbenchmarks unintentionally counting in preparation time (deserialization + conversion toNamedDeBruijn) and partially addresses the issue withvalidationbenchmarks that I ran into in #7177.