Test-suite coverage for type-class laws of core types #785
+1,091
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
QuickCheck
-based property tests for the type-class laws of all data-types exported from theDatabase.LSMtree
module. This PR is motivated by the code coverage discussion from #662. Many of the data-types have non-trivial instances of type-classes and it is prudent to provide assurance that the data-types have lawful instance.Note: Exception data-types were excluded from coverage as they tend to only have a
Show
instance.Here is the coverage improvement of the most impacted modules.
Database.LSMTree
Database.LSMTree.Internal.Config
Database.LSMTree.Internal.Paths
Database.LSMTree.Internal.Range
Database.LSMTree.Internal.Snapshot
Database.LSMTree.Internal.Unsafe