adding functionality to write to datasets #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeenut27
reviewed
Jun 24, 2025
| :param dataset_id: ID of the dataset on SurveyCTO | ||
| :param dataset_title: Optional title for the dataset (defaults to dataset_id) | ||
| :param append: If True, appends data; otherwise replaces the dataset | ||
| :param fill: If True, allows mismatched columns in append mode |
There was a problem hiding this comment.
Looks like this parameter isn't getting used in the function. Can we remove it?
In case of mismatched columns does the API return an error?
| assert isinstance(df, pd.DataFrame), "data must be a pandas DataFrame" | ||
| assert isinstance(dataset_id, str), "dataset_id must be a string" | ||
| if dataset_title is None: | ||
| dataset_title = dataset_id |
There was a problem hiding this comment.
If the dataset_title is not needed for the API, I think we can remove this from the params as well. There is no check that the title is correct and seems redundant. What do you you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.