Skip to content

Ability to use existing database connection #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Ability to use existing database connection #314

wants to merge 2 commits into from

Conversation

worksofliam
Copy link
Member

@worksofliam worksofliam commented Dec 15, 2020

This PR is supposed to cover some of #219, but instead allows the user to pass in a connection instead of relying on itoolkit on creating one. The connections are passed in via the transportOptions object.

Tasks:

  • Pass in an idb-connector connection
  • Pass in an odbc connection
  • Follow linter rules
  • Documentation
  • DCO

@worksofliam worksofliam changed the title Ability to use existing idb connection Ability to use existing database connection Dec 15, 2020
@abmusse
Copy link
Member

abmusse commented Jan 12, 2021

FYI #282 has some code that would allow passing in an odbc connection

@worksofliam I'm thinking this PR should add the ability to pass in existing idb-connector connection.

Adding an existing odbc can be handled in the other PR.

@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Feb 15, 2021
@abmusse abmusse added keep-open Exempts stale action from auto closing the issue/pr. and removed stale labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants