Add ability to start lasso select within object without dragging layers #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemu
commented
Jun 29, 2025
| select_deepest, | ||
| lasso_select, | ||
| select_deepest_key, | ||
| lasso_select_key, |
There was a problem hiding this comment.
renamed this so it's consistent with other similar var names and it let me use lasso_select as a different var in logic below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When beginning a lasso select from within an object, currently the behavior is to drag its layers. This PR updates this behavior such that a lasso select beginning within an object will remain a lasso selection over the existing layers.
NOTE: This is a simpler implementation compared to this alternative approach that includes a small refactor: #2799
Part of #2647
Before
graphite_fix_start_lasso_inside_before.mp4
After
graphite_fix_start_lasso_inside_after.mp4