Improve node graph performance #2795
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
force-pushed
the
node-graph-wire-refactor
branch
from
f333e49 to
e3ebaf9
Compare
adamgerhant
force-pushed
the
node-graph-wire-refactor
branch
from
fc7e515 to
ac01057
Compare
|
!build |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move wire rendering into backend
Implement culling for offscreen nodes
Improves properties/document upgrade stability
Decreases frame time from 120ms -> 20ms when zoomed in on red dress node graph
Increases frame time from 120 -> 200ms when fully zoomed out
Old:
New:
Known issues:
Direct wire paths not supported.
Subpath rectangle_intersections_exist function is buggy, so dragging onto wire is still inconsistent