Skip to content

Feat - Quantstamp Report #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Feat - Quantstamp Report #443

wants to merge 10 commits into from

Conversation

K8oqrQsIlL
Copy link
Contributor

@K8oqrQsIlL K8oqrQsIlL commented Jun 23, 2022

WHAT'S DONE

  • fixed QSP-1 Reentrancy
  • fixed QSP-2 Signed Message May Be Replayed Across Chains
  • fixed QSP-3 Unchecked Return Value
  • fixed QSP-6 Missing Input Validation
  • fixed QSP-10 Token May Have Multiple Labels
  • fixed Automated Analyses 1, 3, 4
  • fixed Adherence to Best Practices 2, 7, 8, 9

TODO

  • make sure we are update backend script for QSP-2 Signed Message May Be Replayed Across Chains
  • make sure we pass non-duplicated array into the contract for QSP-7, QSP-9
  • need to check with Ivan and Abhishek for QSP-4, QSP-5, QSP-8
  • For Automated Analyses 2, Adherence to Best Practices 1, 3

NOTE

  • For Adherence to Best Practices 5, 6, visibility can't be update since they are overridden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant