Refactor royalty #440
Open
Refactor royalty #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the royal fee calculation function is pretty important here. |
xklob
suggested changes
May 12, 2022
| @@ -125,6 +126,10 @@ contract NonFungibleRegistryEnumerableUpgradeable is | |||
| /// @dev The REGISTRAR_ROLE_ADMIN curates the address with REGISTRAR_ROLE permissions | |||
| bytes32 public constant REGISTRAR_ROLE_ADMIN = keccak256("REGISTRAR_ROLE_ADMIN"); | |||
|
|
|||
|
|
|||
| /// @notice used to calculate burn % in calculating royaltyAmount | |||
| uint constant burnDenom = 10000; | |||
| @@ -273,7 +278,8 @@ contract NonFungibleRegistryEnumerableUpgradeable is | |||
|
|
|||
| _createLabeledToken(to, label, registrationData, tokenId); | |||
|
|
|||
| uint256 burnAmount = registrationFee * burnFee / 10000; | |||
| uint256 burnAmount = calculateRoyalty(registrationFee); | |||
There was a problem hiding this comment.
I don't think this is the intended functionality; this function costs "registration token" (ie Hypertoken) to use, and isn't/shouldn't be related to the royalties at all.
| @@ -443,12 +449,16 @@ contract NonFungibleRegistryEnumerableUpgradeable is | |||
| } | |||
| } | |||
|
|
|||
| function calculateRoyalty(uint256 salePrice) internal view returns(uint256 amount) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.