-
-
Notifications
You must be signed in to change notification settings - Fork 59
Survival Refightalized & Monsters Unbound 1.21.5 #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Survival Refightalized & Monsters Unbound 1.21.5 #1108
Conversation
- spamming the shield now disables parries - all elite head blocks now have binding curse - pearlescent laser no longer pierces armor
- re-added chicken jockeys for Lava Chicken music disk - added more sounds to shield parry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through a fair amount of the code now. Great job on the documentation and general neat-ness of the mcfunction files! I've got a couple of nitpicks, but otherwise this looks good to merge.
...und/data/gm4_monsters_unbound/function/mob/process/elite/pearlescent/laser_damage.mcfunction
Outdated
Show resolved
Hide resolved
|
||
# initiate unless mob is pre-marked | ||
execute unless entity @s[tag=gm4_sr_processed] if dimension minecraft:overworld run function gm4_survival_refightalized:mob/init/calc_difficulty_overworld | ||
execute unless entity @s[tag=gm4_sr_processed] unless dimension minecraft:overworld run function gm4_survival_refightalized:mob/init/calc_difficulty_else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should use a dimension tag so that other data packs can make overworld-like dimensions where mobs behave the same as in minecraft:overworld
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there such a thing as a dimension tag? I can't find anything about it
...l_refightalized/data/gm4_survival_refightalized/function/mob/init/mob_type/zombie.mcfunction
Outdated
Show resolved
Hide resolved
...alized/data/gm4_survival_refightalized/function/mob/process/arrow/tick_fire_delay.mcfunction
Outdated
Show resolved
Hide resolved
schedule function gm4_survival_refightalized:main 16t | ||
|
||
# function tag call for expansions to keep clocks sync'd | ||
function #gm4_survival_refightalized:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function tag doesn't exist, which creates a warning in vscode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed two function tags that are probably not that useful, but some are there so outside datapacks can call them, should these have an empty function tag in survival refightalized to remove the warning or is it fine as is?
- death messages only play if showDeathMessages is true - removed useless function tag calls - improved baby zombie predicate - renamed tick_fire_delay function to clock_fire_delay
This PR serves to replace Combat Expanded with Survival Refightalized & Monsters Unbound. The last part, named Augmented Armor is not included here, this is as replacement of the old PR (#1025)
Survival Refightalized
Monsters Unbound