Skip to content

[WIP] Adds lt/lte/gte/gt back to the filter conditions #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Adds lt/lte/gte/gt back to the filter conditions #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d3b205
Adds lt/lte/gte/gt back to the filter conditions
Mar 17, 2020
51fe9e9
Cleans up unused property
Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 17 additions & 22 deletions dist/app.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 20 additions & 20 deletions src/libs/scope.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,27 +38,27 @@ export const filterTypes = [
name: 'notempty',
label: 'Is not empty',
labelVerbose: 'is not empty'
},
{
name: 'gt',
label: 'Greater than',
labelVerbose: 'is greater than'
},
{
name: 'gte',
label: 'Greater than or equal to',
labelVerbose: 'is greater than or equal to'
},
{
name: 'lt',
label: 'Less than',
labelVerbose: 'is less than'
},
{
name: 'lte',
label: 'Less than or equal to',
labelVerbose: 'is less than or equal to'
}
// {
// name: 'gt',
// label: 'Greater than',
// labelVerbose: 'is greater than'
// },
// {
// name: 'gte',
// label: 'Greater than or equal to',
// labelVerbose: 'is greater than or equal to'
// },
// {
// name: 'lt',
// label: 'Less than',
// labelVerbose: 'is less than'
// },
// {
// name: 'lte',
// label: 'Less than or equal to',
// labelVerbose: 'is less than or equal to'
// }
];
export function getFilterScope(filter) {
filter = filter || {};
Expand Down
1 change: 0 additions & 1 deletion src/store/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export function getDefaultNotification() {
audience: '',
_metadata: {
filters: [],
subscriptions: [],
schedule: 'now',
notes: ''
}
Expand Down