PERS-61 [Fix] ensured to open "menu options > menu links" when clicked on "bottom icon bar" menu styles #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squallstar
reviewed
May 9, 2022
js/interface.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| let saveButtonLabel = ''; | |||
There was a problem hiding this comment.
File doesn't look in line with ESLint standards.
There was a problem hiding this comment.
made update to incorporate ESlint standards
tonytlwu
requested changes
May 9, 2022
js/interface.js
Outdated
| @@ -804,11 +805,17 @@ | |||
| attachObservers(); | |||
| // Load menu widgets on startup | |||
| loadCustomMenuWidgets(); | |||
|
|
|||
| // to open menu links | |||
| if (JSON.parse(Fliplet.Navigate.query.data).links === 'true') { | |||
There was a problem hiding this comment.
You should be able to use if (Fliplet.Widget.getData().links). The data returned from Fliplet.Widget.getData() contains data passed through the data query parameter. See https://developers.fliplet.com/API/core/widget.html#get-a-widget-instance-data
There was a problem hiding this comment.
used Fliplet.Widget.getData().links in if statement to assess payload data
…ata function in if case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product areas affected
also in API & Studio
Menu Manger Widget > interface.js
What does this PR do?
Assessing payload from Studio to open Menu Links if applicable
JIRA ticket
PERS-61
Result
PERS-61-.Google.Chrome.2022-05-09.13-35-53.720p.mp4
Checklist
None
Deployment instructions
None
Author concerns
None
Reviewer
@tonytlwu & @squallstar