OD-537 [Fix] Background scrolling in LFD #595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the filters overlay (#10)
OD-478 [Fix] Don't hide LFD if beforeOpen hook was rejected
Revert "OD-478 [Fix] Don't hide LFD if beforeOpen hook was rejected"
OD-478 [Fix] Don't hide LFD if beforeOpen hook was rejected
tonytlwu
requested changes
Jul 28, 2021
| @@ -2028,6 +2034,8 @@ DynamicList.prototype.showDetails = function(id, listData) { | |||
| var template = Handlebars.compile(data.src || src); | |||
| var wrapperTemplate = Handlebars.compile(wrapper); | |||
|
|
|||
| $('.fl-page-content-wrapper').parent().css('overflow', 'hidden'); | |||
There was a problem hiding this comment.
Please explain why this isn't simply $('body')
| @@ -133,6 +133,9 @@ DynamicList.prototype.attachObservers = function() { | |||
| } | |||
|
|
|||
| beforeOpen.then(function() { | |||
| $(event.target).parents('.small-h-card-list-wrapper').addClass('hidden'); | |||
There was a problem hiding this comment.
Please explain why this isn't _this.$container.find('.small-h-card-list-wrapper')
| @@ -306,6 +306,9 @@ DynamicList.prototype.attachObservers = function() { | |||
| } | |||
|
|
|||
| beforeOpen.then(function() { | |||
| $el.parents('.simple-list-container').addClass('hidden'); | |||
There was a problem hiding this comment.
Why is this necessary as part of the solution?
| @@ -1782,7 +1783,7 @@ DynamicList.prototype.animateAgendaForward = function(nextAgendaElement, nextAge | |||
| _this.ANIMATION_SPEED, | |||
| 'swing', // animation easing | |||
| function() { | |||
| _this.$container.find('.agenda-list-day-holder.active').removeClass('active'); | |||
| $dayHolders.removeClass('active').not(nextAgendaElement).addClass('hidden'); | |||
There was a problem hiding this comment.
Please explain how this fix works and why it's necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska @inna-bieshulia
OD-537 https://weboo.atlassian.net/browse/OD-537
Description
Fixed background scrolling in LFD detail view Featured List and display News Feed, Simple List, Agenda layouts when dropping it onto a screen
Screenshots/screencasts
https://storyxpress.co/video/krm0x018st3r4v6eu
https://storyxpress.co/video/krm0ywxvw3oetta5r
Backward compatibility
This change is fully backward compatible.