[Feature] Filter overlay display the number of selected filter options #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytlwu
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
@sofiiakvasnevska This is ready for testing
Risk: Medium
Affected: LFDs with filter overlays
Verify: Filter overlays function as usual in apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://github.com/Fliplet/fliplet-studio/issues/5737
Description
When the user selects a filter number of active filters will be added next to the filter title.
Screenshots/screencasts
https://streamable.com/jx6jpu
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko