Skip to content

Further speed improvements with LFD initial load #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tonytlwu
Copy link
Contributor

@tonytlwu tonytlwu commented Mar 27, 2020

Ref. https://github.com/Fliplet/fliplet-studio/issues/5817

  1. Many functions have been updated to avoid using _.get() with . delimiter (or avoid using _.get() entirely) as this has proven to be quite inefficient.
  2. Assignment of edit and delete permissions are delayed until the entry is opened for the detail view.

Affected functionality

  • Initial load without a limit on initial entries
  • Initial load with a limit on initial entries
  • Render time
  • Opening an entry
  • Opening the "Me" profile in the Directory layout
  • Filtering, search and bookmark filter
  • Social features (bookmark, like, comment)
  • Correctly referencing user's information in while commenting
  • Opening an entry on load (using the dynamicListOpenId parameter)
  • Determining who has access to insert, edit and delete entries

@tonytlwu tonytlwu requested a review from squallstar March 27, 2020 21:55
@tonytlwu tonytlwu changed the title Fixes an issue where filters are not correctly retrieved for LFDs with custom JavaScript before #334 Further speed improvements with LFD initial load Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant