Added the logic to use genus level alignments #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm thinking we might need some clade-level decision making for whether to use genus level data or not. What clade(s) has this been tested on so far?
I'd also like to understand where @ens-ftricomi investigation of the long-read consensus code got to, and how we could merge that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
When creating your Pull request, please fill out the template below:
PR details
Is this a fix/ update/ new feature?
new_feature
Include a short description
I have added a logic in the long read pipeline to use the genus level alignments when the species level is absent. It is worth testing this logic for some species for genus-level alignments. The added feature will look if the long_read_summary_file (Species-level) exists and is non-empty, use it. The long_read_summary_file_genus will not be used or downloaded. But If it's empty or missing, it exits with 42 and goes to branch 2 triggers the download using the genus file and runs the minimap alignments as usual.
Include links to JIRA tickets
https://www.ebi.ac.uk/panda/jira/browse/ENSGENEBUI-2370
Testing
Have you tested it?
Yes
Assign to the weekly GitHub reviewer
If you are a member of Ensembl, please check the Genebuild weekly Rotas and assign this week's GitHub reviewer to the PR