chore(deps): upgrade wry from 0.45.0 to v0.52.0, switch to websocket instead of longpoll #4255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately we can't upgrade to the newest wry until we find a fix for tauri-apps/wry#1551 That bug just entirely breaks android apps for us which is not great. I think this means we will end up switching to a websocket to send binary data into the the webviews, but that's a more complex fix than just the simple upgrade. |
|
That's unfortunate indeed. Changing the actual business logic here is a bit over my head and time budget at the moment. Feel free to either close this PR or leave it open as reference in case someone else tries to upgrade wry. |
jkelleyrtp
changed the title
ealmloff
added
breaking
jkelleyrtp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to look more into #3961 and tried upgrading wry to see if there was a magical fix in the last 6 version. Sadly, I didn't see a difference in that behavior.
Still, I propose upgrading wry anyway to not fall too far behind. Note that this is a breaking change! The signatures for the handlers we expose in the launch config changed. If it's necessary, this can probably be prevented as the new WebViewId is not used for anything. But since we release 0.7 soon I thought this might as well be included
Please note, I have barely an idea what I'm doing here. I just went through the breaking changes in Wry's changelog and adjusted the code accordingly. I can only verify that a basic app seems to still work as expected on my Linux machine.