Update of features/LoadImage #383
Open
+111,492
−3,130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* documented channel2d func * unit tests: channelfirst2d * type hints * Update features.py * NDArray type hint * included Image type hint and xp usage * unit test checks for torch_available * Update features.py * u * docs * linebreak * docs * Update test_features.py * Update test_features.py * deprecation warning & tests * Added support for Image objects * Tests for image objects * docs * tests and axis compatibility * fix for repeated calls * revert changes to upscale * Implemented feedback --------- Co-authored-by: Giovanni Volpe <giovanni.volpe@physics.gu.se>
…ms sometimes arising when unittesting
Pwhsky
reviewed
Jul 12, 2025
| @@ -397,7 +397,7 @@ def get( | |||
| n: int | list[int], | |||
| m: int | list[int], | |||
| coefficient: float | list[float], | |||
| **kwargs: dict[str, Any], | |||
| **kwargs: Any, | |||
| ) -> np.ndarray: | |||
There was a problem hiding this comment.
Type hint should be NDArray if we are swapping from np.ndarray
Pwhsky
reviewed
Jul 12, 2025
| as_list: bool, | ||
| get_one_random: bool, | ||
| **kwargs: Any | ||
| ) -> np.ndarray | torch.tensor | list` |
There was a problem hiding this comment.
Should be ) -> NDArray | torch.Tensor | list.
As torch.Tensor and torch.tensor are not the same we should do a revisal at some point and homogenize this across features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made LoadImage compatible with torch, and updated the documetation and unittesting.
When I tried loading a list, I got an error from the line
while ndim and image.ndim < ndim:,so I changed it to
if not isinstance(image, list) and ndim:while image.ndim < ndim: