Skip to content

Drivetrain #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
05d7bd5
Hghhgn
FriedLongJohns Jan 15, 2025
97e63d2
bug fixes
timtogan Jan 18, 2025
3d72d22
//BabyMode
Niosocket11 Jan 18, 2025
3d4ce23
kSlowNormalBaby Drive and Rot
Niosocket11 Jan 18, 2025
6add2e8
BabyMode un//
Niosocket11 Jan 18, 2025
54f1b76
Got missing stuff added, plus overall cleaner code
Niosocket11 Jan 22, 2025
1e55ae0
Fixed AHRS
Niosocket11 Jan 26, 2025
89fc78e
Adhit Das Commit: Fixed ~30 Drivetrain errors
DriverStationComputer Jan 29, 2025
b4fa953
Fixed SysId and part of measure
Niosocket11 Feb 1, 2025
a6f55cb
Mutable Measure fixed
Niosocket11 Feb 1, 2025
ed1346f
Fixed Drivetrain Port for Gyro
Kenneth-Choothakan Feb 1, 2025
ed71b66
Merge branch 'drivetrain' of https://github.com/DeepBlueRobotics/Robo…
Kenneth-Choothakan Feb 1, 2025
47c642a
Fixed .per thing for time on Drivetrain
Kenneth-Choothakan Feb 1, 2025
aaa5e3f
mutable fully fixed
Niosocket11 Feb 1, 2025
a8ceeec
Merge branch 'drivetrain' of https://github.com/DeepBlueRobotics/Robo…
Niosocket11 Feb 1, 2025
419fb82
Update Drivetrain.java
Niosocket11 Feb 1, 2025
4533dcf
Port gyro fixed
Kenneth-Choothakan Feb 1, 2025
f02f32b
Fixed the .per timeunit line
Kenneth-Choothakan Feb 1, 2025
2f0fc06
Created limelighthelper subystem and rotateRelative command and added…
Kenneth-Choothakan Feb 1, 2025
397764b
Fixed some things in robot container
Kenneth-Choothakan Feb 1, 2025
bacfacc
Final fixes
Niosocket11 Feb 1, 2025
78b6ae7
Wheel base and trackwidth added
Niosocket11 Feb 1, 2025
b5aa93e
Changed motors to new rev lib ones
DriverStationComputer Feb 1, 2025
2f141a8
Added temporary pid testing code to guess and check later
DriverStationComputer Feb 1, 2025
451085c
Updated LimelightHelpers.
DriverStationComputer Feb 2, 2025
1cd5156
Limelight yeeted
Niosocket11 Feb 2, 2025
d746032
Merge branch 'drivetrain' of https://github.com/DeepBlueRobotics/Robo…
DriverStationComputer Feb 2, 2025
a68d948
Changed pid c so it matches turn motor configuration
Kenneth-Choothakan Feb 5, 2025
0a564b3
added 4 pid controllers for turn in an array named turnPidControllers
Kenneth-Choothakan Feb 8, 2025
ed14b0b
Switched around turn and drive ports
Kenneth-Choothakan Feb 12, 2025
adb181b
fixed ports
TuskAct2 Feb 12, 2025
cf2534d
lots of pid testing and stuffs that turn an angle just not the goal a…
Kenneth-Choothakan Feb 15, 2025
acc52a1
changed multiplying turngearing to dividing (this is the correct oper…
Kenneth-Choothakan Feb 15, 2025
42110be
changed turn ff constants in constants.java to 0 in case we end up te…
Kenneth-Choothakan Feb 15, 2025
3b9be01
pid no workee I call RYAAAAAAN
DriverStationComputer Feb 16, 2025
23982cd
Merge branch 'drivetrain' of https://github.com/DeepBlueRobotics/Robo…
DriverStationComputer Feb 16, 2025
1067659
pid has been restored back to normal operations
DriverStationComputer Feb 16, 2025
d1feaf6
pushing so we can test on Kenneth's laptop
DriverStationComputer Feb 16, 2025
c2d0a0d
trying module.move
Kenneth-Choothakan Feb 16, 2025
7d790d3
turned pid using module.move and found turn zeros
Kenneth-Choothakan Feb 17, 2025
2780b5c
got real zeros this time from testing
Kenneth-Choothakan Feb 17, 2025
4933849
updated kS values and drive inversion
Kenneth-Choothakan Feb 17, 2025
19fdba6
build.gradle fixed with propper capitlization on DeepBlueRobotics lin…
DriverStationComputer Feb 18, 2025
fafa90b
doin some sys id tests and also corrected turn zeros
Kenneth-Choothakan Feb 19, 2025
bcee079
fixed the optimization thingy where the module finds the shortest pat…
Kenneth-Choothakan Feb 19, 2025
85593a6
Changed build.grade implementation (line 88) to back 2025-SNAPSHOT si…
Kenneth-Choothakan Feb 19, 2025
2e995ce
All turn pid + ff values gotten, smartdashboard buttons changed to fi…
Kenneth-Choothakan Feb 22, 2025
4feaabe
Updated drive pid, turn pid fixed, shakes a lot
DriverStationComputer Feb 23, 2025
56a79c1
fixed drive kP and inverted one of the motors to fix a bug. drivetrai…
DriverStationComputer Feb 23, 2025
03e8229
adjusting kP and reverted motor inversions to fix drivetrain again
DriverStationComputer Feb 23, 2025
80c7c1b
changed some of constants to have hammer head if statements
Kenneth-Choothakan Mar 5, 2025
26e65f2
more hammerhead constants added
Kenneth-Choothakan Mar 5, 2025
a1a48f1
updated turnPID and drivePID but they need a lot more fixing. pushing…
DriverStationComputer Mar 9, 2025
2b4e91a
Add lib 199 for motorsssssssssssssss
DriverStationComputer Mar 9, 2025
c23ca6d
PID values that actually work for both turn and drive
DriverStationComputer Mar 9, 2025
63f655b
Maybe Fix Joystick Drift?
Niosocket11 Mar 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .DataLogTool/datalogtool.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"download": {
"localDir": "C:\\SysIdLogs",
"serverTeam": "199"
}
}
1 change: 1 addition & 0 deletions .OutlineViewer/outlineviewer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
1 change: 1 addition & 0 deletions .SysId/sysid.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
39 changes: 39 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/java
{
"name": "Java",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/java:1-17-bookworm",

"features": {
"ghcr.io/devcontainers/features/java:1": {
"version": "none",
"installMaven": "false",
"installGradle": "true"
}
},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "",

// Configure tool-specific properties.
"customizations": {
"vscode": {
"extensions": [
"redhat.java",
"ms-vscode.cpptools",
"vcjava.vscode-java-debug",
"ms-toolsai.jupyter",
"vcjava.vscode-java-dependency"
]
}
},

"postAttachCommand": "./.devcontainer/installWPILibExtension.sh && exit"

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
7 changes: 7 additions & 0 deletions .devcontainer/installWPILibExtension.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Modified from ChatGPT suggestions
WPILIB_VSIX_URL=$(curl -s "https://api.github.com/repos/wpilibsuite/vscode-wpilib/releases/latest" | jq -r '.assets[] | select(.name | test(".vsix$")) | .browser_download_url')
INSTALL_LOCATION="/tmp/wpilib-extension/latest.vsix"
echo "$WPILIB_VSIX_URL"
curl --create-dirs -L -o "$INSTALL_LOCATION" "$WPILIB_VSIX_URL"
code --install-extension "$INSTALL_LOCATION"

14 changes: 14 additions & 0 deletions .pathplanner/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"robotWidth": 0.9,
"robotLength": 0.9,
"holonomicMode": true,
"pathFolders": [
"Center Limelight 4 Piece"
],
"autoFolders": [],
"defaultMaxVel": 3.0,
"defaultMaxAccel": 3.0,
"defaultMaxAngVel": 540.0,
"defaultMaxAngAccel": 720.0,
"maxModuleSpeed": 4.5
}
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"java.configuration.updateBuildConfiguration": "disabled"
}
6 changes: 6 additions & 0 deletions .wpilib/wpilib_preferences.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"enableCppIntellisense": false,
"currentLanguage": "java",
"projectYear": "2024",
"teamNumber": 199
}
5 changes: 2 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
plugins {
id "java"
id "edu.wpi.first.GradleRIO" version "2025.2.1"
id "edu.wpi.first.GradleRIO" version "2025.3.1"
id "com.peterabeles.gversion" version "1.10"

}

java {
Expand Down Expand Up @@ -86,7 +85,7 @@ dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

implementation "com.github.deepbluerobotics:lib199:2025-SNAPSHOT"
implementation "com.github.deepbluerobotics:lib199:32da18340af20581b2ef5e17f9d4dfa07c106dbb"
}

test {
Expand Down
1 change: 1 addition & 0 deletions networktables.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
92 changes: 92 additions & 0 deletions simgui-ds.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
{
"keyboardJoysticks": [
{
"axisConfig": [
{
"decKey": 65,
"incKey": 68
},
{
"decKey": 87,
"incKey": 83
},
{
"decKey": 69,
"decayRate": 0.0,
"incKey": 82,
"keyRate": 0.009999999776482582
}
],
"axisCount": 3,
"buttonCount": 4,
"buttonKeys": [
90,
88,
67,
86
],
"povConfig": [
{
"key0": 328,
"key135": 323,
"key180": 322,
"key225": 321,
"key270": 324,
"key315": 327,
"key45": 329,
"key90": 326
}
],
"povCount": 1
},
{
"axisConfig": [
{
"decKey": 74,
"incKey": 76
},
{
"decKey": 73,
"incKey": 75
}
],
"axisCount": 2,
"buttonCount": 4,
"buttonKeys": [
77,
44,
46,
47
],
"povCount": 0
},
{
"axisConfig": [
{
"decKey": 263,
"incKey": 262
},
{
"decKey": 265,
"incKey": 264
}
],
"axisCount": 2,
"buttonCount": 6,
"buttonKeys": [
260,
268,
266,
261,
269,
267
],
"povCount": 0
},
{
"axisCount": 0,
"buttonCount": 0,
"povCount": 0
}
]
}
12 changes: 12 additions & 0 deletions simgui.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"NTProvider": {
"types": {
"/FMSInfo": "FMSInfo",
"/SmartDashboard/Field": "Field2d",
"/SmartDashboard/SendableChooser[1]": "String Chooser"
}
},
"NetworkTables Info": {
"visible": true
}
}
19 changes: 19 additions & 0 deletions src/main/deploy/pathplanner/autos/Circle Path.auto
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "2025.0",
"command": {
"type": "sequential",
"data": {
"commands": [
{
"type": "path",
"data": {
"pathName": "Circle Path"
}
}
]
}
},
"resetOdom": true,
"folder": null,
"choreoAuto": false
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"field_size":{"x":17.548,"y":8.052},"nodeSizeMeters":0.3,"grid":[[true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true],[true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true],[true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true],[true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true],[true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,true,true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,true,true,true,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true],[true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true],[true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true],[true,true,true,true,true,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,false,true,true,true,true,true],[true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true],[true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true,true]]}
102 changes: 102 additions & 0 deletions src/main/deploy/pathplanner/paths/Circle Path.path
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
{
"version": "2025.0",
"waypoints": [
{
"anchor": {
"x": 2.1937499999999996,
"y": 6.418181818181818
},
"prevControl": null,
"nextControl": {
"x": 4.068409090909091,
"y": 7.564914772727272
},
"isLocked": false,
"linkedName": null
},
{
"anchor": {
"x": 6.990085227272727,
"y": 6.268607954545454
},
"prevControl": {
"x": 6.232244318181818,
"y": 6.9965340909090905
},
"nextControl": {
"x": 8.571967417451962,
"y": 4.749168482399608
},
"isLocked": false,
"linkedName": null
},
{
"anchor": {
"x": 6.541363636363636,
"y": 1.0833806818181801
},
"prevControl": {
"x": 8.03211647727273,
"y": 1.768304332386363
},
"nextControl": {
"x": 5.050610795454545,
"y": 0.39845703124999776
},
"isLocked": false,
"linkedName": null
},
{
"anchor": {
"x": 2.951590909090909,
"y": 0.5449147727272714
},
"prevControl": {
"x": 3.7592897727272727,
"y": 0.2756818181818164
},
"nextControl": {
"x": 1.2005926062430576,
"y": 1.1285808736765564
},
"isLocked": false,
"linkedName": null
},
{
"anchor": {
"x": 2.1937499999999996,
"y": 6.418181818181818
},
"prevControl": {
"x": 0.6082670454545456,
"y": 6.029289772727273
},
"nextControl": null,
"isLocked": false,
"linkedName": null
}
],
"rotationTargets": [],
"constraintZones": [],
"pointTowardsZones": [],
"eventMarkers": [],
"globalConstraints": {
"maxVelocity": 3.0,
"maxAcceleration": 3.0,
"maxAngularVelocity": 540.0,
"maxAngularAcceleration": 720.0,
"nominalVoltage": 12.0,
"unlimited": false
},
"goalEndState": {
"velocity": 0,
"rotation": 0.0
},
"reversed": false,
"folder": null,
"idealStartingState": {
"velocity": 0,
"rotation": 0.0
},
"useDefaultConstraints": true
}
45 changes: 45 additions & 0 deletions src/main/java/org/carlmontrobotics/BuildInfo.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package org.carlmontrobotics;

import java.util.Properties;
import java.io.File;
import java.io.InputStream;
import java.nio.file.Path;
import java.nio.file.Files;

import edu.wpi.first.util.sendable.Sendable;
import edu.wpi.first.util.sendable.SendableBuilder;
import edu.wpi.first.wpilibj.Filesystem;

public class BuildInfo implements Sendable {
private Properties props = new Properties();

static private BuildInfo instance = null;

public static BuildInfo getInstance() {
if (instance == null) {
instance = new BuildInfo();
}
return instance;
}

private BuildInfo() {
Path path = Path
.of(Filesystem.getDeployDirectory().getAbsolutePath() + File.separator + "BuildInfo.properties");
try (InputStream is = Files.newInputStream(path)) {
props.load(is);
} catch (Exception ex) {
System.err.println("Error reading build properties from %s".formatted(path));
}
}

@Override
public void initSendable(SendableBuilder builder) {
props.stringPropertyNames().forEach(name -> {
var value = props.getProperty(name);
// Workaround bug (https://github.com/lessthanoptimal/gversion-plugin/pull/14)
// where the gversion plugin surrounds values with quotes.
value = value.replaceAll("\"", "");
builder.publishConstString(name, value);
});
}
}
Loading