-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Kafka consumer integration documentation with configuration ecample #20745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Kafka consumer integration documentation with configuration ecample #20745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions for flow.
@@ -15,7 +15,7 @@ This Agent integration collects message offset metrics from your Kafka consumers | |||
|
|||
### Installation | |||
|
|||
The Agent's Kafka consumer check is included in the [Datadog Agent][2] package. No additional installation is needed on your Kafka nodes. | |||
The Agent's Kafka consumer check is included in the [Datadog Agent][2] package. No additional installation is needed on your Kafka nodes, but configuration is still required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Agent's Kafka consumer check is included in the [Datadog Agent][2] package. No additional installation is needed on your Kafka nodes, but configuration is still required. | |
The Agent's Kafka consumer check is included in the [Datadog Agent][2] package. No additional installation is needed on your Kafka nodes. However, you still need to configure the integration. |
@@ -30,6 +30,15 @@ To configure this check for an Agent running on a host running your Kafka consum | |||
|
|||
1. Edit the `kafka_consumer.d/conf.yaml` file, in the `conf.d/` folder at the root of your [Agent's configuration directory][3]. See the [sample kafka_consumer.d/conf.yaml][4] for all available configuration options. | |||
|
|||
Here's a barebones example configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a barebones example configuration: | |
Here's a basic example configuration to help you get started: |
- kafka_connect_str: kafka:29092 # Replace with your Kafka cluster address | ||
monitor_unlisted_consumer_groups: true | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find more detailed configuration options in the sample configuration file linked above. |
What does this PR do?
Updates docs to make it clear configuration is still needed and provides a quick example on how to get started
Motivation
We'll be linking to the Configuration section in DataDog/documentation#30389 and wanted to make sure it wasn't too burdensome when user lands there in figuring out what's needed to configure the kafka consumer integration
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged