Skip to content

[DOCS-11406] Clean up inaccurate mentions of metrics #30424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Jul 11, 2025

What does this PR do? What is the motivation?

Received internal feedback that "metrics" is being used incorrectly in several areas in ~/browser/data_collected. This is a sweep and check for inaccurate usage of metric/metrics throughout the docs, since metrics now exist with the introduction of RUM without Limits.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@rtrieu rtrieu requested review from a team as code owners July 11, 2025 19:02
@github-actions github-actions bot added the Guide Content impacting a guide label Jul 11, 2025
Copy link
Contributor

github-actions bot commented Jul 11, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@brett0000FF brett0000FF self-assigned this Jul 11, 2025
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now so it's not blocked, but I have a suggestion on the terminology.

It looks like the goal was to separate the new RUM without Limits metrics from raw event data, which makes sense. However, completely replacing the word 'metric' might be an overcorrection that makes things less clear for users.

For example, directly replacing metrics with "telemetry" seems a bit too vague. Our users understand telemetry to mean logs, metrics, traces, but in these examples they are still referring to specific metrics.

What if we standardized on this rule instead?

  • We keep calling the event-level data (like view.time_spent) metrics.
  • We call the aggregated rum.measure.* data Performance Metrics.

I think this would create the intended distinction while still using terms our users know.

Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some changes on /browser/data_collected.md. Could you apply the comments also to the iOS, Android, React Native, Flutter, Roku, and Unity pages please?

Thanks a lot 🙇

rtrieu and others added 2 commits July 16, 2025 10:13
Co-authored-by: Maël Lilensten <mael.lilensten@datadoghq.com>
Co-authored-by: Maël Lilensten <mael.lilensten@datadoghq.com>
@brett0000FF
Copy link
Contributor

@MaelNamNam - Thanks for your replies!

That got me thinking some more, so I did some digging. I found that the term measure is already an established concept for a similar idea:

  • In Logs, measures are defined as quantitative facets used for aggregation.
  • In CI Visibility, users can add custom measures to their pipelines (like dd_measures.binary_size).

With that in mind, it seems like we could adopt this term here? For example:

The RUM SDK generates events that have associated measures and attributes. Measures are quantifiable values (for example, view.time_spent), while attributes are descriptive labels used for filtering (for example, device.type).

What do you think about this? All good either way! Just wanted to offer another idea. Thanks! 🫡

@MaelNamNam
Copy link
Contributor

@brett0000FF measure is not a bad idea, I'm just wondering wether it could cause additional confusion with "RUM Measure", which is one of the new SKUs we introduced with the launch of RUM without Limits.

@brett0000FF
Copy link
Contributor

I'm just wondering wether it could cause additional confusion with "RUM Measure", which is one of the new SKUs we introduced with the launch of RUM without Limits.

@MaelNamNam - Noted! Good point. Our terminology debt definitely makes these challenges tricky. 😅

@MaelNamNam
Copy link
Contributor

Haha and wait till we start tackling miss-usage of tag versus attribute 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants