[docseng-37] copy sourced integrations earlier in the build process to generate placeholder pages #30321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
davidejones
reviewed
Jul 8, 2025
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
davidejones
approved these changes
Jul 8, 2025
hestonhoffman
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This aims to solve the missing placeholder pages from integrations problem.
placeholdersfrom themake dependencieschain so it can happen further down the line. we don't generate placeholders locally, so there's no need to call on it in the Makefile.make update_websites_sources_moduleto usehugo mod vendor, copy the sourced integrations markdown files from websites-sources into docs, and remove the vendor directory immediately. this should only happen in the CI. the_vendorfolder is already gitignored and there is logic to prevent it from running locally anyway, so it would never be committed.new order of operations would be:
dependenciesupdate_websites_sources_moduleplaceholders...
build_sitenow we have the integrations in the file system, we can generate placeholders for them.
https://datadoghq.atlassian.net/browse/DOCSENG-37
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes
QA integrations page: https://docs-staging.datadoghq.com/brian.deutsch/docseng-37-placehold-apw-integrations/integrations/
QA integration details pages
pages that don't have placeholders in live have them in this preview for every language. for example: