Skip to content

[AWS] Switch from using hub CLI to gh for forwarder release #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
+11 −4
Merged

[AWS] Switch from using hub CLI to gh for forwarder release #969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions aws/logs_monitoring/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ if ! command -v yq >/dev/null 2>&1; then
log_error "yq not found, please install it following instructions here https://github.com/mikefarah/yq#install"
fi

if ! command -v hub >/dev/null 2>&1; then
log_error "hub not found, please install it following instructions here https://github.com/github/hub#installation"
if ! command -v gh >/dev/null 2>&1; then
log_error "gh not found, please install it following instructions here https://github.com/cli/cli?tab=readme-ov-file#installation"
fi

# Read the desired version
Expand Down Expand Up @@ -226,8 +226,11 @@ prod_release() {

git add "settings.py" "template.yaml"
git commit --signoff --message "ci(release): Update version from ${CURRENT_VERSION} to ${FORWARDER_VERSION}"
git push origin "${BRANCH_NAME}"

hub pull-request --push --browse --message "Update version from ${CURRENT_VERSION} to ${FORWARDER_VERSION}"
gh pr create --base master --head "${BRANCH_NAME}" \
--title "Update version from ${CURRENT_VERSION} to ${FORWARDER_VERSION}" \
--body "This PR updates the AWS Forwarder version to ${FORWARDER_VERSION} and the layer version to ${LAYER_VERSION}."

if ! user_confirm "Review and merge the pull-request before continuing. Continue"; then
log_error "Aborting... To restart, run the script with PROD_GITHUB_RESTART=true env variable."
Expand Down Expand Up @@ -257,7 +260,11 @@ prod_asset_push() {

# Create a GitHub release
log_info "Releasing aws-dd-forwarder-${FORWARDER_VERSION}, targetting commit ${GIT_COMMIT}, to GitHub..."
hub release create -a "${BUNDLE_PATH}" -m "aws-dd-forwarder-${FORWARDER_VERSION}" -t "${GIT_COMMIT}" "aws-dd-forwarder-${FORWARDER_VERSION}"

gh release create "aws-dd-forwarder-${FORWARDER_VERSION}" "${BUNDLE_PATH}#aws-dd-forwarder-${FORWARDER_VERSION}" \
--title "aws-dd-forwarder-${FORWARDER_VERSION}" \
--target "${GIT_COMMIT}" \
--draft

# Set vars for use in the installation test
TEMPLATE_URL="https://${BUCKET}.s3.amazonaws.com/aws/forwarder/latest.yaml"
Expand Down
Loading