When we shadow, trust the filenames and file sizes. #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
approved these changes
May 25, 2025
|
Hmmm after seeing the issue you filed I'm no longer sure I approve... Have to think more |
|
I removed it from the merge queue for now. We need to think about it maybe more, but currently we can't import these submissions and thus have differences. Maybe we should import them as |
|
In fact I like that: if one of the things from the shadow don't follow our settings, mark it as import error and don't create a judging. Wdyt? |
|
That sounds indeed better and doesn't require us to change internal assumptions |
|
Let me change this PR then |
… import-error Fixes DOMjudge#3005
nickygerritsen
force-pushed
the
shadowing-trust-filenames-and-size
branch
from
a34a27d to
9c9ec9f
Compare
|
Tested this code at NAC dress and it seems to work: |
vmcj
approved these changes
Jul 4, 2025
vmcj
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.