Skip to content

Drag select reimplementation #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 152 commits into
base: master
Choose a base branch
from
Open

Conversation

Crowerade
Copy link
Collaborator

@Crowerade Crowerade commented Jul 9, 2025

Fixes #319.

yinanazhou and others added 30 commits March 4, 2025 14:33
- Update puppeteer to `^19.7.0`
- Fixed crash on loading files

refs: #246
build: update dependencies
fix: replace soundfont-player with smplr
- Added `find_parent_meta_relation`
- Rename `metarel` to `is_meta_relation`
- Use `let` and `const` instead of `var` for best practice

refs: #63
- Rename `find_parent_meta_relations()` to `find_all_parent_relations()`
- Make `find_all_parent_relations()` recursive

closes: #251
- Makes the RelationsTree instance globally accessible via `window.relationTreeInstance`
- Added hierarchy tree updates on creating and deleting relations

closes: #234
fix: recursive (meta-)relation deletion
- Removed npm package dependency and local verovio js file
- Used latest CDN-hosted Verovio
- Fixed key signature rendering

closes: #254
build: switch from local to CDN-hosted Verovio
fix: add filename to file menu and tab title
- Removed unnecessary styles for `.note`
- Added global styles using verovio options and change note color using `color`

refs: #257
style: use Verovio options for note color
fix: update hierarchy tree on editing relation
- Added `draw_slur()`
- Adjusted style for relation

refs: #258
- Added `count_existing_slurs()`
- Adjusted offset for multiple slurs

refs: #258
- Added `adjustSvgDimensions`
@Crowerade Crowerade self-assigned this Jul 9, 2025
@yrammos
Copy link
Member

yrammos commented Jul 9, 2025

⛔️ @Crowerade please change the base branch to develop! The current base branch is master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate drag-select functionality
4 participants