Change compat datagen from enum to interface #8895
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaliszk
reviewed
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow addons/anyone else to define their own mods to have compat-recipes with, instead of being limited to the ones Create supports or having to reimplement the wheel (recipe builder).
Additionally moves the methods in Create's datagen classes that used the recipe/Mods enum to the base class, now using the interface, so some common recipe constructions don't have to be reimplemented either.
Conflicts with my two big open datagen PRs (well not per se, but those introduce new methods that use Mods that should really also use this new interface, could potentially be moved into this PR, relevant commits: e9a2617 69afd90, just let me know and I'll cherry-pick them over)