fix: hand crank rotation visuals #8828
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vercte
added
area: rendering
nopeless
changed the title
|
Give me a second somehow I forgot to patch copper valve visuals properly |
java_VAfXRXfKCO.mp4 |
nopeless
changed the title
|
@nopeless, this pull request is targeting the wrong branch. Pull requests should target the branch corresponding to the earliest supported Minecraft version unless the changes are specific to code that only exists for a newer Minecraft version. Please change the target branch, resolve any merge conflicts, and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks! |
nopeless
force-pushed
the
fix-handcrank-visual
branch
from
27b93b4 to
8cb5abd
Compare
|
commits have been squashed and rebased to 1.20.1/dev |
|
Amazing PR. This has always bothered me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visuals in handcrank don't match the actual rotation. This was caused by not applying proper degrees to radians in rendering. The commit applys them.
Angle semantics for
HandCrankBlockEntitystay as degreesBefore:
javaw_gBuJkGtgtT.mp4
After:
java_DMwvxopO5F.mp4
I also modified
convertToAngular(float speed)function to better explain where the magic3 / 10fconversion value comes from (let me know if you want it removed)TL;DR: codebase mixed degrees and radians and also had a wrong conversion formula in the middle. The resolution taken is only using degrees for
getIndependentAngle()/independentAngleand converting them to radians at render time