Fix all doors sounding like train doors when placed/broken #8575
+32
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoidLeech
added
pr type: fix
VoidLeech
force-pushed
the
mc1.20.1/throwing-rocks-through-a-glass-door
branch
from
4de707d to
92e0945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5738
1.19.4 has moved the soundtype property into the DoorBlock/TrapdoorBlock constructors, overriding the property set in the allblocks file.
Trapdoor wasn't using the glass set type to begin with.
Additionally, the glass type was a duplicated train set type, and no stone set type existed for the andesite/brass/copper doors, which all tried to set the stone soundtype (matching the casings; edit: wait no the casings have the wood sound, should that change the soundtype for the doors? and as pointed out in #8683, the copper casing tries to assign the copper soundtype but still sounds like wood, should that door sound like copper then?).
Deprecates the old TrainTrapdoorBlock constructor (the new constructor + static helpers cover that case), but doesn't remove it since it's used by addons.
Prepended the blocksettypes with
create:. Waifu analysis shows the name field isn't used by anyone, but it is safer should something start using it.