Fix Console methods being split across threads #1622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nik300
changed the title
valentinbreiz
requested changes
Jan 5, 2021
Removing LockSystem that we don't need anymore
Modifying Console.ReadLine and Write to use Mutex instead of LockSystem
|
|
||
| } | ||
|
|
||
| private static List<char> chars = new List<char>(32); |
There was a problem hiding this comment.
Why move chars outside the ReadLine function?
There was a problem hiding this comment.
because if we put them into the function, every thread would have to access its own instance of characters and this would just waste memory and cause errors when threads that don't require "keyboard read" are forced to add to that list(that for them doesn't exist) a character.
| @@ -601,17 +608,21 @@ public static void Write(bool aBool) | |||
| /* Correct behaviour printing null should not throw NRE or do nothing but should print an empty string */ | |||
| public static void Write(object value) => Write((value ?? String.Empty)); | |||
|
|
|||
| private static Cosmos.System.Console xConsole = null; | |||
valentinbreiz
requested changes
Jan 24, 2021
| private static Encoding ConsoleOutputEncoding = Encoding.ASCII; | ||
| private static Encoding ConsoleOutputEncoding = Encoding.ASCII; | ||
| private static Core.Processing.Mutex mConsoleGateRead = new Core.Processing.Mutex(); | ||
| private static Core.Processing.Mutex mConsoleGateWrite = new Core.Processing.Mutex(); |
There was a problem hiding this comment.
Please specify Cosmos.Core.Processing with an using rather than this
There was a problem hiding this comment.
Right. will fix in a moment
|
Stale pull request message |
|
Closing this for same reasons as #1921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should completely fix the bug we had with Console.ReadLine and threads ;)